From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59662: 29.0.50; [PATCH] Add treesit--indent-defun Date: Sat, 03 Dec 2022 08:47:57 +0200 Message-ID: <83r0xhdluq.fsf@gnu.org> References: <5B538888-E454-4F75-B3B8-AB20E10B3E89@gmail.com> <83o7sniokt.fsf@gnu.org> <4D5A1640-4F0F-4C21-8ED6-770B88A870EA@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38274"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 59662@debbugs.gnu.org, theo@thornhill.no, casouri@gmail.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 03 07:49:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1MKp-0009lP-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Dec 2022 07:49:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1MKe-0007Wt-GI; Sat, 03 Dec 2022 01:49:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1MKc-0007Wb-NN for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 01:49:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1MKc-0002mY-FX for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 01:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1MKc-0005YP-51 for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 01:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Dec 2022 06:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59662-submit@debbugs.gnu.org id=B59662.167005010821342 (code B ref 59662); Sat, 03 Dec 2022 06:49:02 +0000 Original-Received: (at 59662) by debbugs.gnu.org; 3 Dec 2022 06:48:28 +0000 Original-Received: from localhost ([127.0.0.1]:51283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1MK3-0005YA-Sh for submit@debbugs.gnu.org; Sat, 03 Dec 2022 01:48:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1MK1-0005Xz-TP for 59662@debbugs.gnu.org; Sat, 03 Dec 2022 01:48:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1MJw-0002gH-5G; Sat, 03 Dec 2022 01:48:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rnT+/TTSVZTMtnuwIBqmTR95NvZCk9ABt1CvoVKoCD4=; b=FmsYDbdSPpTm IjPLTKsulVWqgc4y/cyq6SDVJRyhyze2gJGbCfld3NQpW1wCH2mBPr1+iTqIA75h3QZNsbw8h4EDE OFqiLg3++oaC+CFgIZ8ZiT9N1D7+HGCs1MmSNt5YYVn2NsqsWek8qD8n1GSP8becpPWff/Q0tpe+b i28873MohH29l3b4/sGdQ9rxAPnR8ANbIVPgFpabWotWZzl+Ssk2cM0oNfp2zcOhIYJeUsav52PVi ohvdTg1bS7sx7mVm+kqGt1HMlu9/EKuCur8/rVFIxNpnNfcMkz8WeySqVkHWs57zb4REX5P7FWgUg EHhgGZfRtIW3nRhiNnpq5Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1MJv-000293-Bg; Sat, 03 Dec 2022 01:48:19 -0500 In-Reply-To: (message from Dmitry Gutov on Sat, 3 Dec 2022 00:27:51 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249808 Archived-At: > Date: Sat, 3 Dec 2022 00:27:51 +0200 > Cc: 59662@debbugs.gnu.org, casouri@gmail.org > From: Dmitry Gutov > > On 02/12/2022 22:07, Theodor Thornhill via Bug reports for GNU Emacs, > the Swiss army knife of text editors wrote: > > > > On 2 December 2022 20:53:13 CET, Dmitry Gutov wrote: > >> On 01/12/2022 09:13, Eli Zaretskii wrote: > >>> After all, until now this functionality and the "C-c C-q" > >>> binding was only in CC Mode. > >> There is also the 'M-q' binding in the popular paredit-mode. > >> > >> It runs paredit-reindent-defun. > > Yeah. My first iteration was piggybacking on fill-paragraph-function to get that binding, but I believe that was undesirable. > > IME it's quite handy to have in modes where there is separation between > (rigid) code and strings/comments. > > Not sure if that's all of prog-mode descendants, or if there will be > exceptions. I'm okay with making "C-c C-q" work in more modes than just C-related ones, but please do that on master, not on the release branch. As for M-q, it should be bound to a fill-SOMETHING command, not to a indent-SOMETHING command. So from my POV paredit-mode should be fixed to use some other sequence for paredit-reindent-defun, perhaps even "C-c C-q", but that is IMO an unrelated issue. And if you wanted to suggest that an indent-defun command in c-ts-mode be bound to M-q, then I'm very much against that: M-q already has a useful command bound to it in CC Mode, and should do something similar in c-ts-mode; I believe we are discussing that in bug#59763.