From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make rmail-summary-by-thread faster Date: Sun, 18 Dec 2022 12:25:00 +0200 Message-ID: <83r0wxf1qb.fsf@gnu.org> References: <87a63wnx8h.fsf@autistici.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org, emacs-devel@gnu.org To: Andrea Monaco Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 18 11:25:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6qrW-0009PP-NN for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Dec 2022 11:25:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6qqu-0001wc-34; Sun, 18 Dec 2022 05:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6qqs-0001uT-8f for emacs-devel@gnu.org; Sun, 18 Dec 2022 05:25:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6qqq-0003vI-Px; Sun, 18 Dec 2022 05:25:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xgMaCZOc5Kz1sWWrS9WWkTRCuUB5RMZoDYxJ4mxbCyk=; b=TXTrHB4tLpyu HDB9sy7Ug5NAoOWo1pLXSuWzqPcEvSPNU55otOD2NJmpd9r9Uw6ZwmHFrDJx3xuFd11DIjRZwB4IH QON2fUWfcnmUyPO/0KjOlsZfDX7gWBDaUvbMf/Sr8to1BoMlTx9zji27CB3qsIl/FpS9dsybvD9FN ZEL8sjDrYgCMYKEoLCSCrgRvvPkzUAlfWHQtjuQ6VIC5JgS3nPVQAEUTW/9DUtqYgyDbDzax17mlP 1Dbs51wp1w+BLPPxy7H2cXQST9r9wfx11NwunlKfnqc3COwZc/cn8GQpkTpa/qKC7EKpRDyo5b4xU YLs30/v1hT/M7G658HUttw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6qqj-000091-5W; Sun, 18 Dec 2022 05:24:53 -0500 In-Reply-To: <87a63wnx8h.fsf@autistici.org> (message from Andrea Monaco on Fri, 09 Dec 2022 21:22:22 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301604 Archived-At: > From: Andrea Monaco > Cc: rms@gnu.org, emacs-devel@gnu.org > Date: Fri, 09 Dec 2022 21:22:22 +0100 > > > I found the first implementation of rmail-summary-by-thread a bit slow. > There's an optimization that escaped me at first: generate another > vector called rmail-summary-message-descendants-vector that holds the > direct descendants of each message, that is the symmetric relation to > rmail-summary-message-parents-vector. Now it is much faster. Thanks, I installed this on the emacs-29 branch. P.S. You consistently post patches without commit log messages, which requires me to add the log when installing the changes. Please make a habit of accompanying the patches with the appropriate commit log messages, formatted according to our conventions, as described in the file CONTRIBUTE that you can find in the Emacs source tree. TIA.