From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60565: [PATCH] src/pgtkfns.c (parse_resource_key): Use recursive schema lookup Date: Sat, 07 Jan 2023 13:11:10 +0200 Message-ID: <83r0w6sipd.fsf@gnu.org> References: <83a62uu2rm.fsf@gnu.org> <87sfgmip1p.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35725"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tadfisher@gmail.com, 60565@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 07 12:11:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE76Y-0009C1-CT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Jan 2023 12:11:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE76O-0006mN-5e; Sat, 07 Jan 2023 06:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE76N-0006mE-DM for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 06:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pE76M-0002er-V0 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 06:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pE76M-00042e-Gm for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 06:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60565-submit@debbugs.gnu.org id=B60565.167308985715523 (code B ref 60565); Sat, 07 Jan 2023 11:11:02 +0000 Original-Received: (at 60565) by debbugs.gnu.org; 7 Jan 2023 11:10:57 +0000 Original-Received: from localhost ([127.0.0.1]:56543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE76G-00042I-LW for submit@debbugs.gnu.org; Sat, 07 Jan 2023 06:10:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE76F-000424-EQ for 60565@debbugs.gnu.org; Sat, 07 Jan 2023 06:10:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE76A-0002cL-1G; Sat, 07 Jan 2023 06:10:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GskzrwrCafbNg8CwkSDC3ceH5GLF4bOAkzCZBovuSqU=; b=QHTzBDA7dAZb b60RKbmVYZN99DJD0Cnn8OuNs4Q++ePxsmfT0tDEUe4MEwZOiuRP9thcKfZ1OmHCuZWlSS3w/syvJ sQR+/NauThR678ZnjckCFcIAQyLwp0Q1KnhDiCzng0OxZ6PzwpLzpkKwLyWH6avdmnvDoeOvG5vQn 78RZgYF1YJ0eRCuPa8UoPj++Wcc74ZEO52Vo0LxgNMelyPOUHkCN3HOdBO4/sE22bxvV+o0N3SKQx enSKspW2h+9DmpEfC2zYlGY3pC8JjtcfvYcdL7t86dMrLKEQV2VQIjdfybdepIQT71IKxfP7Gpt8b 8zaLAIK/amNIiXYkF5grjQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE769-0004Vi-K5; Sat, 07 Jan 2023 06:10:49 -0500 In-Reply-To: <87sfgmip1p.fsf@yahoo.com> (message from Po Lu on Sat, 07 Jan 2023 19:04:18 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252783 Archived-At: > From: Po Lu > Cc: Tad Fisher , 60565@debbugs.gnu.org > Date: Sat, 07 Jan 2023 19:04:18 +0800 > > Eli Zaretskii writes: > > >> From: Tad Fisher > >> Date: Thu, 5 Jan 2023 01:58:47 +0000 > >> > >> > >> From 8e2cf80593dd78030929f96f0f1a3e1a325428a4 Mon Sep 17 00:00:00 2001 > >> From: Tad Fisher > >> Date: Wed, 4 Jan 2023 13:40:17 -0800 > >> Subject: [PATCH] ; * src/pgtkfns.c (parse_resource_key): Use recursive schema lookup > >> > >> XDG_DATA_DIRS may consist of multiple directories, and > >> g_settings_schema_source_get_default composes these into a recursive > >> schema source. One must pass TRUE to g_settings_schema_source_lookup, > >> otherwise only the first directory in XDG_DATA_DIRS is searched. > >> > >> It follows that in the case that the directory containing the compiled > >> GSettings schema for Emacs is not the first in XDG_DATA_DIRS, > >> parse_resource_key will not accept any resource key, which causes > >> pgtk_get_defaults_value and pgtk_set_defaults_value to fail. > >> > >> This impacts systems that compose multiple GSettings schema sources > >> via XDG_DATA_DIRS, such Flatpak and NixOS. > >> > >> Supporting GIO documentation for g_settings_schema_source_get_default: > >> > >> > The returned source may actually consist of multiple schema sources > >> > from different directories, depending on which directories were given > >> > in `XDG_DATA_DIRS` and `GSETTINGS_SCHEMA_DIR`. For this reason, all > >> > lookups performed against the default source should probably be done > >> > recursively. > > > > Thanks. Po Lu, any comments? > > Fine by me. Please install if the copyright exemption checks out. It's a single line of code, so the exemption is OK. Should this go to the release branch? IOW, is the problem serious enough and/or was introduced recently enough for us to want it in Emacs 29? Thanks.