From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60886: 29.0.60; split-root-window-below broken for split-window-keep-point Date: Wed, 18 Jan 2023 15:08:11 +0200 Message-ID: <83r0vs0z44.fsf@gnu.org> References: <86k01la7gn.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60886@debbugs.gnu.org To: Juri Linkov , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 18 14:09:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pI8Bk-0002DZ-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Jan 2023 14:09:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI8Bc-0004zZ-8i; Wed, 18 Jan 2023 08:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI8Ba-0004zH-E7 for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 08:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pI8Ba-0004Xl-5f for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 08:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pI8BZ-0002KC-Nl for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 08:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jan 2023 13:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60886 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60886-submit@debbugs.gnu.org id=B60886.16740472878868 (code B ref 60886); Wed, 18 Jan 2023 13:09:01 +0000 Original-Received: (at 60886) by debbugs.gnu.org; 18 Jan 2023 13:08:07 +0000 Original-Received: from localhost ([127.0.0.1]:39776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI8Ah-0002Iy-8X for submit@debbugs.gnu.org; Wed, 18 Jan 2023 08:08:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI8Af-0002IV-R0 for 60886@debbugs.gnu.org; Wed, 18 Jan 2023 08:08:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI8AZ-0004TP-Oz; Wed, 18 Jan 2023 08:07:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1fJKRp5vGwOEXYK9FsuYa4XGoPsW5A/Jo4B36Q4k60k=; b=YpXfJNUJxZ4P KLkDT6P7KtXOH6IoWlgpXmDn+irEFkXw/yMZlGVQD58OAMn6Up49wx/PzuzrX8P89diySQDsyRyP2 sUEOT+3tsWxs/VjBLvkdLP+XEZ/qDIG1PGslHrRvR8pOp+rqbI3e4brULMU0Vg213AoFEknQTB/iV VP+UR9h6wsA4jPlhZ7/YbqzdD/ZRrLKPJ+iYEiRT7GkHJR7V6soYaRD6G/lV546+Y3SPaGpaszhs7 g+fo4/n6sW49fSY969InYYqbSBGWp61u6B+SN1wYL/i+6E23A/9E56Dn1+LPtGY+W3DOWDfgbRsUO 7mKWMKWgA9T5kguq/xUaeg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI8AZ-0005kv-1g; Wed, 18 Jan 2023 08:07:59 -0500 In-Reply-To: <86k01la7gn.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 17 Jan 2023 19:10:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253629 Archived-At: > From: Juri Linkov > Date: Tue, 17 Jan 2023 19:10:48 +0200 > > etc/NEWS: > > *** New commands 'split-root-window-below' and 'split-root-window-right'. > These commands split the root window in two, and are bound to 'C-x w 2' > and 'C-x w 3', respectively. > > 0. emacs -Q > 1. (setq split-window-keep-point nil) > 2. C-x w 2 > 3. C-x w 2 > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > split-window-below(nil #) > split-root-window-below(nil) > funcall-interactively(split-root-window-below nil) > command-execute(split-root-window-below) > > diff --git a/lisp/window.el b/lisp/window.el > index 4099b707009..53d34a3bf6e 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -5670,7 +5675,8 @@ split-window-keep-point > > (defun split-window-below (&optional size window-to-split) > "Split WINDOW-TO-SPLIT into two windows, one above the other. > -WINDOW-TO-SPLIT is above. The newly split-off window is > +WINDOW-TO-SPLIT defaults to the selected window and after > +splitting remains above. The newly split-off window is "Remains" is not a good word here: we are splitting the window in two, so none of them "remains". I'd say "...and will be above the other window after splitting". > (defun split-window-right (&optional size window-to-split) > "Split WINDOW-TO-SPLIT into two side-by-side windows. > -WINDOW-TO-SPLIT is on the left. The newly split-off window is on > +WINDOW-TO-SPLIT defaults to the selected window and after > +splitting remains on the left. The newly split-off window is on > the right and displays the same buffer. Return the new window. Same here. Martin, any comments?