From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60740: [PATCH 0/2] emoji changes Date: Sat, 04 Feb 2023 14:29:27 +0200 Message-ID: <83r0v5txzs.fsf@gnu.org> References: <83leli3nly.fsf@gnu.org> <20230201230918.550-1-jonas@bernoul.li> <83zg9tu91v.fsf@gnu.org> <874js1vdo7.fsf@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27889"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60740@debbugs.gnu.org, larsi@gnus.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 04 13:30:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOHgW-00075M-RY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Feb 2023 13:30:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOHgG-0006fY-TX; Sat, 04 Feb 2023 07:30:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOHgD-0006fI-9k for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 07:30:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOHgA-000540-UI for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 07:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOHgA-0006nu-Ca for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60740 X-GNU-PR-Package: emacs Original-Received: via spool by 60740-submit@debbugs.gnu.org id=B60740.167551377726075 (code B ref 60740); Sat, 04 Feb 2023 12:30:02 +0000 Original-Received: (at 60740) by debbugs.gnu.org; 4 Feb 2023 12:29:37 +0000 Original-Received: from localhost ([127.0.0.1]:40816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOHfi-0006mS-9k for submit@debbugs.gnu.org; Sat, 04 Feb 2023 07:29:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOHfd-0006mB-9l for 60740@debbugs.gnu.org; Sat, 04 Feb 2023 07:29:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOHfX-00050t-2Z; Sat, 04 Feb 2023 07:29:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oy5uPVlSXVXP10Ldr2ek7OarMZZG7ydnVJ3lQiYCOx8=; b=MCH4hM1KXItS wxQdZ37rEyfisaOuK9wh01T0mbt0wkldsuBa16DZaKxhBsfSx26Xw0o5OB/onbxH6yXpcJTW7ULt+ srYGwLFDemJoHlrXz2HJRdiI/KQN3UQtV2xK7teGeOVA8KfoIYBH8GsHSRNE93r8Fuphok98JEXdC CPlY8CygwFUdgK3XHjmwm7AKXgxZ2yFICFC8MyQvTdGEtmQzeCP4BiXy2MsGx0A/Z3ic9badTIwpX u+iFuwBlfZsczS5f9aaZ/FQ1lBjmD/hHfYHspiLyFTRbselu5Uk9CFMBd3Nfi3yXvI4Y5Qe3nsK5h mixPQr9S/aw4G2rYofysZg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOHfW-0000gf-7Q; Sat, 04 Feb 2023 07:29:22 -0500 In-Reply-To: <874js1vdo7.fsf@bernoul.li> (message from Jonas Bernoulli on Sat, 04 Feb 2023 13:05:28 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254772 Archived-At: > From: Jonas Bernoulli > Cc: 60740@debbugs.gnu.org, larsi@gnus.org > Date: Sat, 04 Feb 2023 13:05:28 +0100 > > Eli Zaretskii writes: > > > Thanks. > > > > Would it make sense to install the first patch on the emacs-29 branch > > and the second on master? Or did I misunderstand your explanations > > above? AFAIU, the first patch solves the immediate issue in this bug, > > right? > > That's correct and it would make sense to do it like this. At the same > time I think that it is risky both to install and not install the second > patch on emacs-29. On the one hand past changes to transient did not > break emoji, even though I did not specifically try to prevent that. On > the other the risk of that happening going forward is not zero. If Lars > finds the time to look at the refactoring before the pre-release, I > think it would be best to install it on emacs-29, but if not, I am find > with it going on master instead. My suggestion is for now to install the first patch on emacs-29 and the second one on master. We can always backport from master to emacs-29 if we decide so later. >From my POV at this time, it is important to resolve the few remaining issues that prevent us from starting the Emacs 29 pretest, and this issue is one of them. Which is why I suggest to do the above now, and consider backporting the second patch to emacs-29 later if we have time. Thanks.