From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: textconv.c
Date: Sun, 12 Feb 2023 14:58:16 +0200
Message-ID: <83r0uvghw7.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="40272"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Po Lu <luangruo@yahoo.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 12 13:59:21 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1pRBwv-000AIU-Dc
	for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Feb 2023 13:59:21 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1pRBwM-00050D-KC; Sun, 12 Feb 2023 07:58:46 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1pRBwK-0004ze-Pg
 for emacs-devel@gnu.org; Sun, 12 Feb 2023 07:58:44 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1pRBwK-0005bB-G8; Sun, 12 Feb 2023 07:58:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=ev8K4nuB5JhGr0iuojcamFbjHQpC9rjncsNrNFsEDjA=; b=ZbbKl9goilNUcJ
 Q5yp+kJRuY/l9iDGmh5k/BA2Ap5/VgtMde9zT2lRnmOvPzJKe6qNJopseBzWxGEiMf9mr3Zt08/Ji
 TO2N4JyPDoyxIuafq8vP5J0zkZwG8Bfo5R/WYN/6tkSu4/ZpzN1lU3v/+L6IxWTLtZwmUTp6uXeLh
 5zAqBARXdRkJtHBIQ3xGTJIUTyoRDfWjzWSHSYsGLTNVU7EFPm7+hzWLaMmqcP6v6LpTCZoW9k+DF
 i5YNoPoiny8DJ8sII/WREqX+YUmtcLDs/sqav7wnk1Qr9QpH0Pz+C/AJHEIv6JYA2PMA+N9W6AbJa
 Se6HEiJ8wehGpeav9oMg==;
Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1pRBwK-00053K-01; Sun, 12 Feb 2023 07:58:44 -0500
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:303172
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/303172>

Please move the code which manipulates buffer text and the gap to
insdel.c.  And I don't really understand why you needed to add
copy_buffer, since we already have insert_from_buffer and copy_text.

The rest (textconv_query) should go to some existing file(fns.c,
perhaps?).  There's no justification for a new file for such a little
code.

Thanks.

P.S. I wonder why you couldn't ask about this before doing this stuff.
This list is supposed to be used for such design discussions.