all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: textconv.c
Date: Sun, 12 Feb 2023 14:58:16 +0200	[thread overview]
Message-ID: <83r0uvghw7.fsf@gnu.org> (raw)

Please move the code which manipulates buffer text and the gap to
insdel.c.  And I don't really understand why you needed to add
copy_buffer, since we already have insert_from_buffer and copy_text.

The rest (textconv_query) should go to some existing file(fns.c,
perhaps?).  There's no justification for a new file for such a little
code.

Thanks.

P.S. I wonder why you couldn't ask about this before doing this stuff.
This list is supposed to be used for such design discussions.



             reply	other threads:[~2023-02-12 12:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 12:58 Eli Zaretskii [this message]
2023-02-12 14:05 ` textconv.c Po Lu
2023-02-12 14:32   ` textconv.c Eli Zaretskii
2023-02-12 15:06     ` textconv.c Eli Zaretskii
2023-02-12 15:35       ` textconv.c Po Lu
2023-02-12 15:27     ` Android input methods (was: Re: textconv.c) Po Lu
2023-02-12 15:57       ` Eli Zaretskii
2023-02-13  2:21         ` Android input methods Po Lu
2023-02-13 13:49           ` Eli Zaretskii
2023-02-13 14:37             ` Po Lu
2023-02-13 15:17               ` Eli Zaretskii
2023-02-13 17:04                 ` Eli Zaretskii
2023-02-14  1:57                 ` Po Lu
2023-02-14 14:32                   ` Eli Zaretskii
2023-02-14 15:14                     ` Po Lu
2023-02-14 17:01                       ` Eli Zaretskii
2023-02-15  2:13                         ` Po Lu
2023-02-12 16:00       ` Android input methods (was: Re: textconv.c) Lynn Winebarger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0uvghw7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.