From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: luangruo@yahoo.com, abdo.haji.ali@gmail.com, 62573@debbugs.gnu.org
Subject: bug#62573: 29.0.60; Cursor color not being inverted in emacs-29
Date: Sun, 02 Apr 2023 14:12:42 +0300 [thread overview]
Message-ID: <83r0t2wn9x.fsf@gnu.org> (raw)
In-Reply-To: <m1355i35vw.fsf@yahoo.es> (message from Daniel Martín on Sun, 02 Apr 2023 13:01:07 +0200)
> From: Daniel Martín <mardani29@yahoo.es>
> Cc: luangruo@yahoo.com, 62573@debbugs.gnu.org, abdo.haji.ali@gmail.com
> Date: Sun, 02 Apr 2023 13:01:07 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Daniel Martín <mardani29@yahoo.es>
> >> Cc: Al Haji-Ali <abdo.haji.ali@gmail.com>, 62573@debbugs.gnu.org,
> >> luangruo@yahoo.com
> >> Date: Sat, 01 Apr 2023 21:56:33 +0200
> >>
> >> This bug is a regression caused by
> >> 07715630ad9df9cb681cbadecbaf73fc9c698061. (Adding Po Lu to the CC.)
> >>
> >> >From what I see, the font display refactor removed this code from
> >> src/nsterm.m:
> >>
> >> - face = FACE_FROM_ID_OR_NULL (f, phys_cursor_glyph->face_id);
> >> - if (face && NS_FACE_BACKGROUND (face)
> >> - == ns_index_color (FRAME_CURSOR_COLOR (f), f))
> >> - {
> >> - [ns_lookup_indexed_color (NS_FACE_FOREGROUND (face), f) set];
> >> - hollow_color = FRAME_CURSOR_COLOR (f);
> >> - }
> >> - else
> >>
> >> which seems to be responsible for the cursor color change when the
> >> background face color is the same as the cursor color. I can't find
> >> that logic in the current code, so I think we miss it from the
> >> refactoring.
> >>
> >> I've solved the bug by replicating that logic in the appropriate places,
> >> nsterm.m and macfont.m:
> >
> > This regression should be fixed on the release branch, but the patch
> > you propose is quite large. Can't we simply reinstate the removed
> > code, and apply the changes you propose only on master?
> >
>
> That's the first thing I tried, but it didn't fix the problem. More
> code changes would be needed because, since
> 07715630ad9df9cb681cbadecbaf73fc9c698061, the responsibility of drawing
> the cursor now resides in the macOS font driver (macfont.m).
OK, thanks, understood.
next prev parent reply other threads:[~2023-04-02 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 18:34 bug#62573: 29.0.60; Cursor color not being inverted in emacs-29 Al Haji-Ali
2023-03-31 19:15 ` Eli Zaretskii
2023-03-31 21:46 ` Al Haji-Ali
2023-04-01 5:38 ` Eli Zaretskii
2023-04-01 19:56 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 0:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 21:24 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-03 0:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-06 10:12 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-08 11:36 ` Eli Zaretskii
2023-04-02 5:09 ` Eli Zaretskii
2023-04-02 5:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 6:58 ` Eli Zaretskii
2023-04-02 11:01 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-02 11:12 ` Eli Zaretskii [this message]
2023-04-02 14:28 ` Al Haji-Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0t2wn9x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62573@debbugs.gnu.org \
--cc=abdo.haji.ali@gmail.com \
--cc=luangruo@yahoo.com \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.