From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Tue, 30 May 2023 19:32:23 +0300 Message-ID: <83r0qxg4q0.fsf@gnu.org> References: <87a5xrzsph.fsf@stebalien.com> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> <83mt1rjg69.fsf@gnu.org> <875y8fm7x7.fsf@gmail.com> <83lehbjdjd.fsf@gnu.org> <87wn0vkqn1.fsf@gmail.com> <83jzwvj94x.fsf@gnu.org> <87h6rw8y82.fsf@gmail.com> <83353gipww.fsf@gnu.org> <87edmzto0l.fsf@gmail.com> <83ilcbgrxo.fsf@gnu.org> <87zg5nb3m3.fsf@gmail.com> <83bki3gpai.fsf@gnu.org> <87sfbfazfp.fsf@gmail.com> <837csrgioe.fsf@gnu.org> <87jzwqb7r3.fsf@gmail.com> <83ttvuf29m.fsf@gnu.org> <87a5xmaqul.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 30 18:32:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q42Gk-0003VM-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 May 2023 18:32:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q42GS-0005cS-3T; Tue, 30 May 2023 12:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q42GQ-0005bt-7t for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 12:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q42GP-0007wX-WC for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q42GP-0003hT-Nh for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 12:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2023 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168546431714214 (code B ref 63731); Tue, 30 May 2023 16:32:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 30 May 2023 16:31:57 +0000 Original-Received: from localhost ([127.0.0.1]:34032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q42GL-0003hB-Em for submit@debbugs.gnu.org; Tue, 30 May 2023 12:31:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q42GG-0003gx-OZ for 63731@debbugs.gnu.org; Tue, 30 May 2023 12:31:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q42GB-0007uF-Cn; Tue, 30 May 2023 12:31:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jVXwkeQlHaF/8OdXWYW7ndEvEnB5uaeU1WakyJVnpY0=; b=pOJPhF67qaQ5iCa9eOgJ CanevsuLC0kzc9QL2qefgcMn2CSsP0h7TrBxPAxf7esCyfYcRDCoCfljZOO55ygilvCyat6/hZ1xp c9PsXidrPugG8uwS10PbWk1LxVrHdq+kqOEFOO1xM/numuzEATuc0UkSU6QQ9mWlA+/RfLLWju4ry c39bKJqBPfbPbhhMMnPtTnivjKJoHXu+NgR0XN/m9YRU7E6cx3EHygCUD4W25UfgDG8hkkYP8LLJH h7/XSjG3LgCGfLvQ/0uxHFNV3qZJ71ZQ7QPuMd/kN4HtYkGzpLLwMcfsSCBPxt3f/JTFWUM0bs2UW dk6zAh1ZfHAGmA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q42G6-0002E6-5q; Tue, 30 May 2023 12:31:46 -0400 In-Reply-To: <87a5xmaqul.fsf@gmail.com> (message from Robert Pluim on Tue, 30 May 2023 15:30:58 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262637 Archived-At: > From: Robert Pluim > Cc: 63731@debbugs.gnu.org, steven@stebalien.com > Date: Tue, 30 May 2023 15:30:58 +0200 > > >>>>> On Tue, 30 May 2023 15:10:45 +0300, Eli Zaretskii said: > > Eli> Which means it _is_ composed. Moreover, with Noto Color Emoji we get > Eli> a single glyph. On my system, I have Noto Emoji, from which I get two > Eli> glyphs: > > Eli> [0 1 128077 422 17 1 15 12 2 nil] > Eli> [0 1 65039 3 17 0 1 0 1 [0 0 0]] > > Eli> (in which case I can understand why the second one is displayed as a > Eli> hex box if I customize glyphless-char-display-control). > > But I also get a hex box if I customize > glyphless-char-display-control, even though 'C-u C-x =' claims thereʼs > only one glyph. > > Eli> So, given that this is the case, why is this wrong, again? If the > Eli> font and the shaper produce two glyphs, or one glyph that looks like > Eli> two, why should we think it's an Emacs's problem? > > Because Emacs behaves differently depending on whether we have a > composition rule for FE0F that looks backwards or one for 1F44D that > looks forwards. The sequence in both cases is > > U+1F44D U+FE0F U+7C U+61 > U+1F44D U+7C U+61 > > (set-char-table-range > composition-function-table > #xFE0F > '(["\\c.\ufe0f" 1 font-shape-gstring])) > > produces the following: > > There is a (very) thin space that shouldnʼt be there between the 1f44d > and the '|' on the line that has the FE0F (and since it follows the > value of glyphless-char-display-control, I donʼt think > it comes from the shaping engine). OK, here's the scoop: there's no composition there. "C-u C-x =" says there is, but that's a lie: when I look in GDB at the glyphs actually shown there, there's no composition glyphs, only the glyph for U+1F44D followed by a glyph for U+FE0F. > but > > (set-char-table-range > composition-function-table > #x1F44D > '(["\U0001f44d\ufe0f" 0 font-shape-gstring])) > > gives me this, where the two '|' align perfectly. Here, there _is_ a composition. So there are two issues here: (a) why there's no composition in the first case, and (b) why does "C-u C-x =" says there is when there isn't.