From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Tue, 06 Jun 2023 14:59:40 +0300 Message-ID: <83r0qo3ioj.fsf@gnu.org> References: <83r0qq3zo3.fsf@gnu.org> <87edmog836.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 06 14:03:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6VPj-00041C-It for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Jun 2023 14:03:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6VLt-0003DQ-Hc; Tue, 06 Jun 2023 07:59:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6VLj-0002rO-35 for emacs-devel@gnu.org; Tue, 06 Jun 2023 07:59:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6VLg-0006IJ-7x; Tue, 06 Jun 2023 07:59:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HOGMQNlQxpnthSw9VMk+2tq0WZZmncKxvGk6XqEAG4g=; b=LS3mRTFNMjsQ AXEnVtinyET6mz4RpviZUxnMUZ0qtAJ+RqzSQN0lsp71k/4ltG8qXBQbFeNMwsEsIGBmKaBL6y9qE i7t/XX8zf1vqAbL6nCE7fyjBHsHzczKLpJ/zjQskR+IZnFOdN/WPCEoOv2iuthNAy16S7VLq2XIFm STAoLHINfa7q+1IVt9WPdNbEQTRbrGv27bG0YgU6FTKN61ymTzAaDu+sY+IRmbxTUzIrr4sP/rdW2 /QJKtC5HomTuF/9IlHuLMKo4fVrhVkGJe3XOBiWtN0aPVM7JvnR8nzdTD3LsmyvfjU+KCYU8nwSjC +2snD4kDCznV8QKo22DipA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6VLf-0004MM-ED; Tue, 06 Jun 2023 07:59:40 -0400 In-Reply-To: <87edmog836.fsf@melete.silentflame.com> (message from Sean Whitton on Tue, 06 Jun 2023 12:10:05 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306664 Archived-At: > From: Sean Whitton > Cc: emacs-devel@gnu.org > Date: Tue, 06 Jun 2023 12:10:05 +0100 > > > In the future, please always accompany user-visible changes with > > suitable changes to one or both of our manuals, to make sure the > > manuals are kept up-to-date at all times. > > I know to do this in general, but in this case the new function is in > subr-x, and my understanding was that functions in that file are not to > be documented in any manuals. Are you suggesting I move it to subr.el? My primary concern is about documenting useful features. In which files to put the implementation is secondary, from my POV. We don't need to be 110% consistent in this regard, btw. > Regarding NEWS, CONTRIBUTE says > > There is no need to mention files such as NEWS and MAINTAINERS, or to > indicate regeneration of files such as 'lib/gnulib.mk', in the > ChangeLog entry. "There is no need" means you don't have to, but you > can if you want to. > > Should that text perhaps be updated? Why? the last sentence already covers my request, doesn't it? > > As for the name of the new function: what do people think about > > renaming it to eval-interactive-spec? I don't think we need the > > "command" part. > > In that case, what would we rename advice-eval-interactive-spec to, when > we drop the 'advice-' prefix? That function exists for quite some time, so renaming it is a much harder decision.