From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64075: 28.2; ispell broken on uncolored terminals Date: Thu, 15 Jun 2023 10:48:56 +0300 Message-ID: <83r0qdtbbr.fsf@gnu.org> References: <42ff58c7e8e4095a1f34@heytings.org> <835y7puw0z.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38537"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64075@debbugs.gnu.org, gregory@heytings.org To: Al Petrofsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 09:49:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9hjE-0009lX-1i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 09:49:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9hj5-0000lc-RU; Thu, 15 Jun 2023 03:49:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9hj4-0000lU-Tb for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 03:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9hj4-0006bb-Ko for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 03:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9hj4-0001RE-Gy for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 03:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64075 X-GNU-PR-Package: emacs Original-Received: via spool by 64075-submit@debbugs.gnu.org id=B64075.16868153215493 (code B ref 64075); Thu, 15 Jun 2023 07:49:02 +0000 Original-Received: (at 64075) by debbugs.gnu.org; 15 Jun 2023 07:48:41 +0000 Original-Received: from localhost ([127.0.0.1]:46066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9hij-0001QW-4K for submit@debbugs.gnu.org; Thu, 15 Jun 2023 03:48:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9hih-0001Q6-C7 for 64075@debbugs.gnu.org; Thu, 15 Jun 2023 03:48:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9hib-0006Wp-Kt; Thu, 15 Jun 2023 03:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ajEcmnGkMbuFLObGZ+WbbSMG/YfCw4BFlc/Eu+VcylE=; b=ZICGYAPqHshm RPrCrUOD0jh/XuHRVis7cHA3LUYL0zkqU4GZLzSvU7xT4kObsqtQypXoZb1icqbw/UZQ16hWuEL2r yeREKo+3YPK8KDcsWCrsp1o6P8wHxz7pKXiL1b8/8pSgtXoCM89stGZbRt5c1uPTry2qfTyskmIae xjiJHcLsa30LNmBLOYRIHO29mibxteyByHHKkIeqxIWdzXZbDo9IpDnx5nFeX/DWDImSLMdznECqO pBLaPVhmCj8XJom/2N46aCQb54dPcfwX7+9K8GrTghoHUj44gJ47tBIvQMQFK8xQVDTWaRKiE/1xu Oc2EuVeUSAetQJM6uxfeCA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9hib-0000rc-5I; Thu, 15 Jun 2023 03:48:33 -0400 In-Reply-To: (message from Al Petrofsky on Thu, 15 Jun 2023 02:34:48 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263406 Archived-At: > From: Al Petrofsky > Date: Thu, 15 Jun 2023 02:34:48 -0400 > Cc: gregory@heytings.org, 64075@debbugs.gnu.org > > What's anachronistic about that code (meaning the > ispell-highlight-spelling-error-generic function) is that it uses a > kludge that made it possible in pre-version-21 emacs to get some text > displayed in inverse video on a tty even though emacs could not > display faces on ttys. But since Emacs 21, on any tty that has a > termcap "so" capability, you can get inverse-video simply by using an > inverse-video face. That this was written before Emacs 21 doesn't yet make it not useful now. > So I don't think ispell-highlight-spelling-error-generic currently > provides any functionality that isn't more conveniently and > maintainably provided by ispell-highlight-spelling-error-overlay, with > the additional benefit that the user can, if he wants, customize > ispell-highlight-face to something other than inverse-video. It's a working code whose replacement (basically, a cleanup) will mean extra work for us, and all that for quite rare situations. Based on my long experience with Emacs, it also means some subtle bugs in some even rarer use cases, which will take years to find and fix. No, thanks. > (Making the default isearch face (and therefore the default > ispell-highlight-face) be blue-on-magenta on color terminals but > inverse-video on monochrome terminals is already handled > automatically.) You've ignored what I wrote about that possibility: when faces are customized by users, they are usually customized in simplistic ways, and are thus unlikely to work for all the cases. IOW, once you allow for face customizations, it is very hard to make sure this face will still be distinct on a colorless terminal. If you or someone wants to present a patch that will make more terminals use ispell-highlight-spelling-error-overlay, and includes in that patch a suitable change to the ispell-highlight-face, then I'll gladly review it. Otherwise, I see this issue as closed by that last-year bugfix.