From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64329: 29.0.92; treesit/fill-paragraph syntax highlighting problem Date: Thu, 29 Jun 2023 08:22:49 +0300 Message-ID: <83r0puu9jq.fsf@gnu.org> References: <3031A934-37EC-497D-8A48-ECE7FD703B31@gmail.com> <14493480-9226-4AB1-A313-E4E2D61AB0BD@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: brownts@troybrown.dev, 64329@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 07:23:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEk8C-0009Yv-Vn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 07:23:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEk7r-0007BD-EE; Thu, 29 Jun 2023 01:23:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEk7V-0007An-E2 for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 01:23:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEk7S-0001mZ-Kr for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 01:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEk7S-0003jm-GV for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 01:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 05:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64329 X-GNU-PR-Package: emacs Original-Received: via spool by 64329-submit@debbugs.gnu.org id=B64329.168801615114299 (code B ref 64329); Thu, 29 Jun 2023 05:23:02 +0000 Original-Received: (at 64329) by debbugs.gnu.org; 29 Jun 2023 05:22:31 +0000 Original-Received: from localhost ([127.0.0.1]:52068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEk6w-0003iZ-Rl for submit@debbugs.gnu.org; Thu, 29 Jun 2023 01:22:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEk6t-0003iM-Ui for 64329@debbugs.gnu.org; Thu, 29 Jun 2023 01:22:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEk6o-0001hD-Fc; Thu, 29 Jun 2023 01:22:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=pRaOq7ZpCQ6x9gfIBNf94Ny0G5+gFO1NclVwk06MpK4=; b=H9Gu6dzutFNA9ELxru2J H9DqGtZBOYYDlc1sTJuqHPBMsd9f5EQocEvO5H//FyRcChdbqg0f/FxPkkOhSmw065jh/FLRknuy/ EF7e8G/vmk9VkdIVR1S40yQ5TCo7hZzlaOq8RagF5L1VWs5VWmaEVcl/8vhbD1jbG5RK9UhIpOOPb Yw7IQQ8be3v/4J/f7vf6CqtjiR4Qmem35wZ1JlfFuV8M3uumLOoBr/ZkpdpzMMJvxziAIlyVdV13h fpBEuf2U7nLyMWizjfmg1OIt/eowuik8VocXTFZ1ErWcFwns7tFSs6YiVshuHfGEiKzxPoGQND7eI qWkkhGC7nqk6QQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEk6n-0005iv-GE; Thu, 29 Jun 2023 01:22:22 -0400 In-Reply-To: <14493480-9226-4AB1-A313-E4E2D61AB0BD@gmail.com> (message from Yuan Fu on Wed, 28 Jun 2023 17:17:14 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264255 Archived-At: > From: Yuan Fu > Date: Wed, 28 Jun 2023 17:17:14 -0700 > Cc: 64329@debbugs.gnu.org, > Eli Zaretskii > > Prompted by this, I went over all the functions that calls signal_after_change again, and found two other editfns.c functions that are missing calls to treesit_record_change. Please see the attached patches that follows the previous one. Sorry for the overlook. I believe I’ve found all places that needs to call treesit_record_change now. > > > Please see the attached patch. Eli, is it more preferable to add a subroutine in insdel.c that does what "for (i = 0; i < len; i++) *p++ = tostr[I];” does, plus calling treesit_record_change, and make subst-char-in-region call that subroutine? (This way editfns.c don’t need to include treesit.h and call treesit_record_change itself.) > > Since now there are three functions in editfns.c that needs to call treesit_record_change, we might as well just include treesit.h and call treesit_record_change directly. Right.