all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#65105: Reusing the same string as 'display on consecutive characters evades display
@ 2023-08-05 18:35 JD Smith
  2023-08-05 19:03 ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: JD Smith @ 2023-08-05 18:35 UTC (permalink / raw)
  To: 65105

Evaluate:

(let ((s1 "test1")
      (s2 "test2"))
  (insert "\n"
          (propertize " " 'display s1)
          (propertize " " 'display s1)
          (propertize " " 'display s2)
          (propertize " " 'display s1)))


The first space display does not take effect, since the s1 string is used for two consecutive characters.  This has a practical impact for font-lock backends that use the ‘display text-property and would like to minimize string allocation.  

Tested Emacs 27/28/29.






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-05 18:35 bug#65105: Reusing the same string as 'display on consecutive characters evades display JD Smith
@ 2023-08-05 19:03 ` Eli Zaretskii
  2023-08-05 20:49   ` JD Smith
  0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-05 19:03 UTC (permalink / raw)
  To: JD Smith; +Cc: 65105

tags 65105 notabug
thanks

> From: JD Smith <jdtsmith@gmail.com>
> Date: Sat, 5 Aug 2023 14:35:23 -0400
> 
> Evaluate:
> 
> (let ((s1 "test1")
>       (s2 "test2"))
>   (insert "\n"
>           (propertize " " 'display s1)
>           (propertize " " 'display s1)
>           (propertize " " 'display s2)
>           (propertize " " 'display s1)))
> 
> 
> The first space display does not take effect, since the s1 string is used for two consecutive characters.  This has a practical impact for font-lock backends that use the ‘display text-property and would like to minimize string allocation.  

Emacs cannot distinguish between two consecutive characters having
each a text property with the same value, and two characters having
the same property.  If you think about this for a moment, you will
understand why: we use intervals for text properties, so two adjacent
intervals with the identical property values and one interval with
that same value are indistinguishable (and in fact Emacs optimizes
this during GC by making just one interval from these two).

This is not a bug.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-05 19:03 ` Eli Zaretskii
@ 2023-08-05 20:49   ` JD Smith
  2023-08-05 22:46     ` Dmitry Gutov
  0 siblings, 1 reply; 8+ messages in thread
From: JD Smith @ 2023-08-05 20:49 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 65105

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]


> On Aug 5, 2023, at 3:03 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> tags 65105 notabug
> thanks
> 
>> From: JD Smith <jdtsmith@gmail.com>
>> Date: Sat, 5 Aug 2023 14:35:23 -0400
>> 
>> Evaluate:
>> 
>> (let ((s1 "test1")
>>      (s2 "test2"))
>>  (insert "\n"
>>          (propertize " " 'display s1)
>>          (propertize " " 'display s1)
>>          (propertize " " 'display s2)
>>          (propertize " " 'display s1)))
>> 
>> 
>> The first space display does not take effect, since the s1 string is used for two consecutive characters.  This has a practical impact for font-lock backends that use the ‘display text-property and would like to minimize string allocation.  
> 
> Emacs cannot distinguish between two consecutive characters having
> each a text property with the same value, and two characters having
> the same property.  If you think about this for a moment, you will
> understand why: we use intervals for text properties, so two adjacent
> intervals with the identical property values and one interval with
> that same value are indistinguishable (and in fact Emacs optimizes
> this during GC by making just one interval from these two).
> 
> This is not a bug.

Aha, thanks.  It does make sense from an optimization standpoint to “gang” properties in this manner.  Are you aware of any approach that allow re-using a string for ‘display, but permits consecutive intervals to remain distinct?

[-- Attachment #2: Type: text/html, Size: 9939 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-05 20:49   ` JD Smith
@ 2023-08-05 22:46     ` Dmitry Gutov
  2023-08-05 22:49       ` JD Smith
  2023-08-06  4:54       ` Eli Zaretskii
  0 siblings, 2 replies; 8+ messages in thread
From: Dmitry Gutov @ 2023-08-05 22:46 UTC (permalink / raw)
  To: JD Smith, Eli Zaretskii; +Cc: 65105

On 05/08/2023 23:49, JD Smith wrote:
> Aha, thanks.  It does make sense from an optimization standpoint to 
> “gang” properties in this manner.  Are you aware of any approach that 
> allow re-using a string for ‘display, but permits consecutive intervals 
> to remain distinct?

Overlays? But they have certain performance problems when their number 
grows.

Or you could try resolving this manually: when the previous character is 
assigned with the same line, do a copy-sequence, and when it's a 
different one, you can use the "singleton" one.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-05 22:46     ` Dmitry Gutov
@ 2023-08-05 22:49       ` JD Smith
  2023-08-06  4:55         ` Eli Zaretskii
  2023-08-06  4:54       ` Eli Zaretskii
  1 sibling, 1 reply; 8+ messages in thread
From: JD Smith @ 2023-08-05 22:49 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: Eli Zaretskii, 65105

That’s probably the right approach.  Or even simpler, allocate two identical strings and alternate.  Thanks.

> On Aug 5, 2023, at 6:46 PM, Dmitry Gutov <dmitry@gutov.dev> wrote:
> 
> On 05/08/2023 23:49, JD Smith wrote:
>> Aha, thanks.  It does make sense from an optimization standpoint to “gang” properties in this manner.  Are you aware of any approach that allow re-using a string for ‘display, but permits consecutive intervals to remain distinct?
> 
> Overlays? But they have certain performance problems when their number grows.
> 
> Or you could try resolving this manually: when the previous character is assigned with the same line, do a copy-sequence, and when it's a different one, you can use the "singleton" one.






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-05 22:46     ` Dmitry Gutov
  2023-08-05 22:49       ` JD Smith
@ 2023-08-06  4:54       ` Eli Zaretskii
  2023-08-06 17:48         ` Dmitry Gutov
  1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-06  4:54 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 65105, jdtsmith

> Date: Sun, 6 Aug 2023 01:46:49 +0300
> Cc: 65105@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
> 
> On 05/08/2023 23:49, JD Smith wrote:
> > Aha, thanks.  It does make sense from an optimization standpoint to 
> > “gang” properties in this manner.  Are you aware of any approach that 
> > allow re-using a string for ‘display, but permits consecutive intervals 
> > to remain distinct?
> 
> Overlays? But they have certain performance problems when their number 
> grows.

Not in Emacs 29 and later, right?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-05 22:49       ` JD Smith
@ 2023-08-06  4:55         ` Eli Zaretskii
  0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-06  4:55 UTC (permalink / raw)
  To: JD Smith; +Cc: dmitry, 65105-done

> From: JD Smith <jdtsmith@gmail.com>
> Date: Sat, 5 Aug 2023 18:49:11 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>,
>  65105@debbugs.gnu.org
> 
> That’s probably the right approach.  Or even simpler, allocate two identical strings and alternate.  Thanks.

And with that, I'm closing this bug.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65105: Reusing the same string as 'display on consecutive characters evades display
  2023-08-06  4:54       ` Eli Zaretskii
@ 2023-08-06 17:48         ` Dmitry Gutov
  0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Gutov @ 2023-08-06 17:48 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 65105, jdtsmith

On 06/08/2023 07:54, Eli Zaretskii wrote:
>> Date: Sun, 6 Aug 2023 01:46:49 +0300
>> Cc:65105@debbugs.gnu.org
>> From: Dmitry Gutov<dmitry@gutov.dev>
>>
>> On 05/08/2023 23:49, JD Smith wrote:
>>> Aha, thanks.  It does make sense from an optimization standpoint to
>>> “gang” properties in this manner.  Are you aware of any approach that
>>> allow re-using a string for ‘display, but permits consecutive intervals
>>> to remain distinct?
>> Overlays? But they have certain performance problems when their number
>> grows.
> Not in Emacs 29 and later, right?

Hopefully not -- I haven't benchmarked any particular problem cases 
recently.

But I'm guessing the package JD is working on aims to support previous 
versions anyway.





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-08-06 17:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-05 18:35 bug#65105: Reusing the same string as 'display on consecutive characters evades display JD Smith
2023-08-05 19:03 ` Eli Zaretskii
2023-08-05 20:49   ` JD Smith
2023-08-05 22:46     ` Dmitry Gutov
2023-08-05 22:49       ` JD Smith
2023-08-06  4:55         ` Eli Zaretskii
2023-08-06  4:54       ` Eli Zaretskii
2023-08-06 17:48         ` Dmitry Gutov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.