From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Possible bug: org-capture fails when emacs started as daemon Date: Wed, 16 Aug 2023 20:04:56 +0300 Message-ID: <83r0o27wav.fsf@gnu.org> References: <87ttt3dkad.fsf@localhost> <87jztwdz7k.fsf@ice9.digital> <87o7j8p7k1.fsf@localhost> <83wmxw8776.fsf@gnu.org> <871qg3wcav.fsf@gmx.com> <83cyzn84nm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15688"; mail-complaints-to="usenet@ciao.gmane.io" Cc: inigoserna@gmx.com, yantar92@posteo.net, morgan@ice9.digital, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 16 19:05:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWJxg-0003oW-61 for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Aug 2023 19:05:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWJx2-00071B-5C; Wed, 16 Aug 2023 13:04:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWJwy-0006sO-3N for emacs-devel@gnu.org; Wed, 16 Aug 2023 13:04:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWJww-000511-O6; Wed, 16 Aug 2023 13:04:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JN2eB4HbPyiYaN4voVJjSZpDDs5+HBGiaWH56oV9wnc=; b=VwRQhNWxY3F1 ykNvYI1QtFYDn4sN5hYZ8zSvv2BVgPpmCKupR8oHr8v6EB9KRRj+7d5VIsLCnnUgz6Lm/zb9w9Icf pLm/loCtWKANVHWwywq3iJWAZ5OdXyuyubyAyaskLhL/icydaztkBvgiddIZFwiW6z5xCpDX8nnmK qePnUsVobPvfOrAjL5cQygVbvvnWTgFie1X42gSSecDWX4y9abgVQTSZ4xopRLdKbmjIw/IY8IDaZ FK8mLcy6qitY3HUpr7fci3Vprd0bXSs5mZ/5Ev9W+lAaB2zxvByyJP1Fgl9/56iisYZDomcVXL8kV R7RfQc33rjcYgFCbWTPa4w==; In-Reply-To: (message from Stefan Monnier on Wed, 16 Aug 2023 11:00:21 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308829 Archived-At: > From: Stefan Monnier > Cc: inigoserna@gmx.com, yantar92@posteo.net, morgan@ice9.digital, > emacs-devel@gnu.org > Date: Wed, 16 Aug 2023 11:00:21 -0400 > > If we want to make the code simpler, then we should throw away > `face-remap--copy-face` and use `copy-tree` instead. Like below? diff --git a/lisp/face-remap.el b/lisp/face-remap.el index 3ec271b..c5f7af3 100644 --- a/lisp/face-remap.el +++ b/lisp/face-remap.el @@ -70,21 +70,10 @@ internal-lisp-face-attributes :foreground :background :stipple :overline :strike-through :box :font :inherit :fontset :distant-foreground :extend :vector]) -(defun face-remap--copy-face (val) - "Return a copy of the `face' property value VAL." - ;; A `face' property can be either a face name (a symbol), or a face - ;; property list like (:foreground "red" :inherit default), - ;; or a list of such things. - ;; FIXME: This should probably be shared to some extent with - ;; `add-face-text-property'. - (if (or (not (listp val)) (keywordp (car val))) - val - (copy-sequence val))) - (defun face-attrs--make-indirect-safe () "Deep-copy the buffer's `face-remapping-alist' upon cloning the buffer." (setq-local face-remapping-alist - (mapcar #'face-remap--copy-face face-remapping-alist))) + (mapcar #'copy-tree face-remapping-alist))) (add-hook 'clone-indirect-buffer-hook #'face-attrs--make-indirect-safe)