From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: gerd.moellmann@gmail.com, 66288@debbugs.gnu.org,
gregory@heytings.org, eggert@cs.ucla.edu, cph@chris-hanson.org
Subject: bug#66288: 29.1; Performance regression using pipe for subprocess
Date: Thu, 05 Oct 2023 08:50:06 +0300 [thread overview]
Message-ID: <83r0m94nzl.fsf@gnu.org> (raw)
In-Reply-To: <8be747c8-42e5-f978-d331-b8c36c6d0349@gutov.dev> (message from Dmitry Gutov on Thu, 5 Oct 2023 01:54:43 +0300)
> Date: Thu, 5 Oct 2023 01:54:43 +0300
> Cc: gregory@heytings.org, gerd.moellmann@gmail.com, 66288@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 05/10/2023 01:49, Paul Eggert wrote:
> >> + fcntl (inchannel, F_SETPIPE_SZ, readmax);
> >
> > This call can fail if you aren't root and you exceed the system limit in
> > /proc/sys/fs/pipe-max-size. So I suggest that if this fnctl fails with
> > EPERM, trying it again after clipping to that limit.
>
> Perhaps we'd rather fail loudly, so the user is aware that their
> customized value cannot be applied.
Why not silently? The clip_to_bounds call can already silently change
the original request anyway.
next prev parent reply other threads:[~2023-10-05 5:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 0:57 bug#66288: 29.1; Performance regression using pipe for subprocess Chris Hanson
2023-10-01 8:39 ` Eli Zaretskii
2023-10-01 18:02 ` Chris Hanson
2023-10-02 5:02 ` Eli Zaretskii
2023-10-02 5:07 ` Eli Zaretskii
2023-10-02 17:14 ` Chris Hanson
2023-10-02 5:36 ` Eli Zaretskii
2023-10-02 18:22 ` Chris Hanson
2023-10-02 19:12 ` Gerd Möllmann
2023-10-02 19:27 ` Dmitry Gutov
2023-10-02 19:40 ` Gerd Möllmann
2023-10-02 20:15 ` Dmitry Gutov
2023-10-02 23:23 ` Chris Hanson
2023-10-03 5:06 ` Gerd Möllmann
2023-10-03 6:22 ` Eli Zaretskii
2023-10-03 6:48 ` Eli Zaretskii
2023-10-03 17:24 ` Eli Zaretskii
2023-10-03 19:12 ` Chris Hanson
2023-10-03 20:22 ` Dmitry Gutov
2023-10-03 17:42 ` Dmitry Gutov
2023-10-03 17:57 ` Eli Zaretskii
2023-10-03 20:58 ` Gregory Heytings
2023-10-03 21:26 ` Dmitry Gutov
2023-10-04 0:33 ` Chris Hanson
2023-10-04 6:52 ` Eli Zaretskii
2023-10-04 9:10 ` Gregory Heytings
2023-10-04 10:09 ` Dmitry Gutov
2023-10-04 17:55 ` Chris Hanson
2023-10-04 22:49 ` Paul Eggert
2023-10-04 22:54 ` Dmitry Gutov
2023-10-05 5:50 ` Eli Zaretskii [this message]
2023-10-05 10:48 ` Dmitry Gutov
2023-10-06 5:34 ` Eli Zaretskii
2023-10-05 5:49 ` Eli Zaretskii
2023-10-04 4:11 ` Gerd Möllmann
2023-10-04 6:55 ` Eli Zaretskii
2023-10-03 7:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0m94nzl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66288@debbugs.gnu.org \
--cc=cph@chris-hanson.org \
--cc=dmitry@gutov.dev \
--cc=eggert@cs.ucla.edu \
--cc=gerd.moellmann@gmail.com \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.