From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67207: [PATCH] Add elixir-ts-mode-hook to elixir-ts-mode Date: Sat, 18 Nov 2023 12:03:55 +0200 Message-ID: <83r0knml84.fsf@gnu.org> References: <874jhmn9us.fsf@gmail.com> <835y22ren0.fsf@gnu.org> <8734x6rdvz.fsf@gmail.com> <834jhmrdpw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8675"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wkirschbaum@gmail.com, 67207-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 18 11:05:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4ICf-00020d-W9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Nov 2023 11:05:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4ICG-0004cL-H1; Sat, 18 Nov 2023 05:05:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4ICE-0004Zy-09 for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 05:05:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4ICD-000429-Ld for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 05:05:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4ICE-0000El-5d for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 05:05:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2023 10:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 67207@debbugs.gnu.org, eliz@gnu.org, wkirschbaum@gmail.com Original-Received: via spool by 67207-done@debbugs.gnu.org id=D67207.1700301845834 (code D ref 67207); Sat, 18 Nov 2023 10:05:01 +0000 Original-Received: (at 67207-done) by debbugs.gnu.org; 18 Nov 2023 10:04:05 +0000 Original-Received: from localhost ([127.0.0.1]:47836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4IBJ-0000DO-Gy for submit@debbugs.gnu.org; Sat, 18 Nov 2023 05:04:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4IBI-0000Cu-4O for 67207-done@debbugs.gnu.org; Sat, 18 Nov 2023 05:04:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4IBC-0003uY-2L; Sat, 18 Nov 2023 05:03:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4hKdRHML3RwFL6FTSWY6N+cKSnTx5J4fxs31R32OFQI=; b=UitSuq2Wmvgh R+FhNDUuu7AXqp226Jr6DmChLY43O8hqiqgkx8P6uGJXqslXNWkH8kfeQwpYQ5rHSWJUJXVDMF63b H+HbcyWFH3Ar4yN+LbQ/gg8gTBZO/5lbab0Om0v7cRAzWhKgCUFwyfFzjvIrVEeC5OiMq0sy+4gPr 3ufvIC4PNeHSIt8O//W1gvukn/e5EdwlPJvWUJxxdJEtqjW0Qo6CVWDF3yYwFgEn7+hPg1bqERmxO E1a5xh9XKDiTSdVF2mm1V/JlbuGmE8MGESUfjGATRIVqvQtB8yYPjhE2mUOQEwi0snKV3Xa5QK7vG RR2+WhDIT+ocQAgUqnOSXA==; In-Reply-To: (message from Stefan Monnier on Wed, 15 Nov 2023 17:53:52 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274545 Archived-At: > From: Stefan Monnier > Cc: Wilhelm Kirschbaum , 67207@debbugs.gnu.org > Date: Wed, 15 Nov 2023 17:53:52 -0500 > > > Stefan, does this mean define-derived-mode has some deficiency? > > Many/most modes defined using it don't have an explicit hook > > definition, so should we now define a mode hook for all of them? > > Usually we don't have good ideas of `:options` to provide for hook > variables, so it's not very useful to expose them to Custom. > > Also, it's not rare for hook variables to be modified by other packages, > which again votes in favor of not exposing them to Custom. > > But some mode maintainers do like to expose them to Custom for their > users' convenience. Usually I look at it as a hint that there's > something missing elsewhere (for the patch at hand, maybe some kind of > `global-eglot-mode` would be a better answer in the longer term). > > We could try and extend `define-derived-mode` to allow it to expose the > hook to Custom, with `:options` and whatnot, but it doesn't seem worth > the trouble since the maintainer can use a separate explicit `defcustom` > instead, as the OP's patch does. Thanks, I installed the change and added a comment regarding the reasons. Closing.