From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67650: [PATCH] ; Hide completion preview when switching windows Date: Wed, 06 Dec 2023 14:04:54 +0200 Message-ID: <83r0jz4jvd.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24893"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67650@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 06 13:06:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAqfP-0006Aq-Ea for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Dec 2023 13:06:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAqf3-0005JY-7r; Wed, 06 Dec 2023 07:05:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAqf1-0005Is-3n for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 07:05:51 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rAqf0-0001H0-PB for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 07:05:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rAqfC-0006Wv-2u for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 07:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Dec 2023 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67650 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67650-submit@debbugs.gnu.org id=B67650.170186430725033 (code B ref 67650); Wed, 06 Dec 2023 12:06:02 +0000 Original-Received: (at 67650) by debbugs.gnu.org; 6 Dec 2023 12:05:07 +0000 Original-Received: from localhost ([127.0.0.1]:38972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAqeI-0006Vh-Li for submit@debbugs.gnu.org; Wed, 06 Dec 2023 07:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAqeH-0006VB-CH for 67650@debbugs.gnu.org; Wed, 06 Dec 2023 07:05:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAqdz-0000vL-An; Wed, 06 Dec 2023 07:04:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=b+nzy7kSyosWk29IjbP5FIsuwXfAUhQaujMU642Q9to=; b=TqclJQ85k2/y pKXxcozDlcN5uKkF1EbKn2zvWMRUSvNv+zZ6YQtPH280xPNIb0PDhU8OZLchEEcIZ28jCrn8o2yBJ UwdvYV2m0DDbj2XJrQSAGYl3l5pjQw1/LSZDkzP6cCw66QPb1kdMdoW8agC1iYaCZIkNRVgASH/Y/ jIx/8GpLJNB/pUp2/+jpAaDcIWFUENhKCf7eU9hCjtKYiX8i4Srjp1iijbuu7bRm5X9OGEc5LJr7+ Jc5/pxQSeaNEDaKB+bKgE9NSYNZ/BnNSTr4yi03fBLFholF+i6J0x83auTu/5ijqGD0AgFk/KqDJZ L8fCSNqcyVgtUO8RpGkR4w==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275588 Archived-At: > Date: Tue, 05 Dec 2023 21:26:27 +0100 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch ensures that we dismiss the completion preview when users > switch to another window. Previously, the completion preview would > remain in a window after switching to another window showing another > buffer, since the `post-command-hook` that Completion Preview mode sets > up locally doesn't run after a command switches to another buffer. Sorry, I don't understand: why does it matter whether post-command-hook runs _after_ switching to another buffer? When and why would a command that caused post-command-hook invocation NOT need to dismiss the preview? If post-command-hook should always dismiss the preview, then we shouldn't need another hook, right?