From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Treesit says grammar is unavailable when it Date: Thu, 14 Dec 2023 10:27:30 +0200 Message-ID: <83r0jpqjd9.fsf@gnu.org> References: <1b24fc47-f792-415c-ac59-fcf3a2f5eeb9@gmail.com> <83r0jqs46e.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gernotk@gmail.com, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 14 09:28:15 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDh4o-0000FB-Nw for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Dec 2023 09:28:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDh4B-00054h-Qr; Thu, 14 Dec 2023 03:27:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDh49-00054U-LQ for emacs-devel@gnu.org; Thu, 14 Dec 2023 03:27:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDh49-0000dy-Bv; Thu, 14 Dec 2023 03:27:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1zH1Za6egwxtn6y8HiqrDneS4/noW0SxEsTHyFgu9zw=; b=Ejc4n8TP++0o 0bacy76MspN8HkB0FJkU2tX/tgTT21SmVsjqRxiX9zZyBzbkI+jLAzkGNO3/uR//UQkFwrJYhGRDY sHFSFRiHRdXliqpDddBw1mtJdQ8fRLRzUDmSa/uphsGE/S+BbJEP1pxo7QxXWhxJ090PkiKaDu26U foeyga1c85H0B5qNkkQ2y5gQkIFFoNPDkVxE51+e2hq9Ff1K5rAnmDBCQ/ANuD26loc4z5TjgblgH Pem6BHfLb5ZjJU9ZW4ZXjA8QDcRxjEpDOevK8mLZ4p4KjWFN/Hn+XXAzFmDFwTBl9VK6rylF6nbSp P2W/FKyEjW9x5WwUXLKdSA==; In-Reply-To: (message from Yuan Fu on Thu, 14 Dec 2023 00:14:01 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313761 Archived-At: > From: Yuan Fu > Date: Thu, 14 Dec 2023 00:14:01 -0800 > Cc: gernotk@gmail.com, > emacs-devel@gnu.org > > >> Thanks for sharing this! Eli, this sort of thing might be good reasons > >> to also print the error message from ldopen, rather than simply saying > >> not found? > > > > I don't mind, but IME relying too much on these error messages is not > > always a good idea, since sometimes they are too generic and say > > nothing except "this failed". But if it will help in some cases, > > let's do it. > > > > However, I would like to see the patch, since we seem to be signaling > > an error already, and the error includes the error message from > > dynlib_open? So what am I missing? > > We were showing error messages from dlopen, and then removed them for brevity, see e8df6c311fcf59bf23d31b9db2bb8fec9d78fbe7 If these messages are useful, we can revert that commit. > Maybe we can fold the extra error messages by default? I'm not sure I understand the details, but the idea is certainly okay.