From: Eli Zaretskii <eliz@gnu.org>
To: awrhygty@outlook.com, Stefan Monnier <monnier@iro.umontreal.ca>,
Stefan Kangas <stefankangas@gmail.com>,
Juri Linkov <juri@linkov.net>
Cc: 67925@debbugs.gnu.org
Subject: bug#67925: 29.1; delete-rectangle fails on multi-column characters
Date: Thu, 21 Dec 2023 18:46:26 +0200 [thread overview]
Message-ID: <83r0jffqql.fsf@gnu.org> (raw)
In-Reply-To: <TYZPR01MB392074B6D4ED4843EBAB6FA1C395A@TYZPR01MB3920.apcprd01.prod.exchangelabs.com> (awrhygty@outlook.com)
> From: awrhygty@outlook.com
> Cc: 67925@debbugs.gnu.org
> Date: Thu, 21 Dec 2023 23:26:05 +0900
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> This patch gives similar result of kill-rectangle.
> >> In the example above, I want all '4' characters moved to same column.
> >
> > How can that be done, when the first character takes 2 or more
> > columns? Deleting the first character is IMO wrong, since the other
> > lines leave the first character intact. Adding SPC to other lines is
> > also wrong, since delete-rectangle is not supposed to _add_ columns.
>
> I think wide characters may be replaced with SPC like TAB.
I don't think I agree. Let's see what others think Stefan, Juri,
Stefan, any opinions? Does anyone else have an opinion on this?
> >> And TAB characters crossing the end column are not edited correctly
> >> with delete-rectangle if indent-tabs-mode is on.
> >>
> >> 012345678
> >> 8(TAB at head)
> >> 012345678
> >>
> >> The text above is edited to the text below.
> >> 45678
> >> 8(TAB at head)
> >> 45678
> >>
> >> If indent-tabs-mode is off, the result is the text below.
> >> 45678
> >> 8(four SPCs)
> >> 45678
> >
> > This is a separate issue with the original code. It also happens with
> > kill-rectangle, btw. We could fix it by temporarily binding
> > indent-tabs-mode to nil inside these commands -- would that be
> > acceptable? The result will be that the killed rectangle includes
> > spaces, not the leading TAB.
>
> I prefer that the killed rectangle has same column for each line.
> If TAB is included when yanking, the current column affects the width of
> the yanked string for each line.
Again, does anyone else have an opinion here? I tend to think that we
should bind indent-tabs-mode to nil inside those functions.
next prev parent reply other threads:[~2023-12-21 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 10:58 bug#67925: 29.1; delete-rectangle fails on multi-column characters awrhygty
2023-12-20 14:09 ` Eli Zaretskii
2023-12-21 7:30 ` awrhygty
2023-12-21 8:42 ` Eli Zaretskii
2023-12-21 14:26 ` awrhygty
2023-12-21 16:46 ` Eli Zaretskii [this message]
2023-12-21 21:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-22 7:56 ` Juri Linkov
2023-12-22 11:45 ` Eli Zaretskii
2023-12-22 14:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 17:30 ` Juri Linkov
2023-12-23 18:07 ` Eli Zaretskii
2023-12-24 8:31 ` Juri Linkov
2023-12-24 14:52 ` Stefan Kangas
2023-12-28 9:01 ` Eli Zaretskii
2024-01-03 19:00 ` awrhygty
2024-01-03 19:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r0jffqql.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67925@debbugs.gnu.org \
--cc=awrhygty@outlook.com \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.