all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: luangruo@yahoo.com, 68018-done@debbugs.gnu.org
Subject: bug#68018: [PATCH] Fix previous page and next page tooltips in doc-view.el
Date: Sat, 30 Dec 2023 09:42:13 +0200	[thread overview]
Message-ID: <83r0j43zmy.fsf@gnu.org> (raw)
In-Reply-To: <m1mstylfhs.fsf@yahoo.es> (bug-gnu-emacs@gnu.org)

> Cc: 68018@debbugs.gnu.org
> Date: Mon, 25 Dec 2023 11:54:07 +0100
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > Daniel Martín <mardani29@yahoo.es> writes:
> >
> >> In docview.el, the toolbar icons used to navigate to the previous and
> >> next pages have incorrect tooltips.  I've attached a patch to address
> >> this issue.  Thanks.
> >
> > Thanks, but why rename the icon?
> 
> So that the name of the icon matches what the icon really represents.
> If you feel that renaming the icon may cause incompatibilities, here’s a
> new patch that only changes the help tooltip.  Thanks.

Thanks, installed on master, and closing the bug.





      parent reply	other threads:[~2023-12-30  7:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m1tto7kxrs.fsf.ref@yahoo.es>
2023-12-24 23:04 ` bug#68018: [PATCH] Fix previous page and next page tooltips in doc-view.el Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25  0:26   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 10:54     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 11:59       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 12:22         ` Eli Zaretskii
2023-12-25 12:59           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 13:40             ` Eli Zaretskii
2023-12-25 14:23               ` Stefan Kangas
2023-12-26  2:02               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-27 12:38                 ` Eli Zaretskii
2023-12-27 13:02                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-27 13:39                     ` Eli Zaretskii
2023-12-30  7:42       ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r0j43zmy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68018-done@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.