From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Thu, 04 Jan 2024 18:39:02 +0200 Message-ID: <83r0ixvys9.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20328"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68244@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 04 17:40:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLQlV-00053A-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jan 2024 17:40:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLQlE-0005z0-7x; Thu, 04 Jan 2024 11:40:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLQlC-0005ya-QQ for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 11:39:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLQlC-000882-I7 for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 11:39:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLQlF-0002XW-QZ for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 11:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 16:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.17043863859732 (code B ref 68244); Thu, 04 Jan 2024 16:40:01 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 4 Jan 2024 16:39:45 +0000 Original-Received: from localhost ([127.0.0.1]:55525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLQky-0002Wt-Un for submit@debbugs.gnu.org; Thu, 04 Jan 2024 11:39:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLQkw-0002Wa-1A for 68244@debbugs.gnu.org; Thu, 04 Jan 2024 11:39:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLQkk-00084Y-Us; Thu, 04 Jan 2024 11:39:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SFsT7pA1yMZQprxTAC4oSWejIjPke+Pjs6iDMb2aA+A=; b=MvVHClVP7DHcxNdEDZi+ ZVrbl9QdJpfo5bQ/LG7cB5nhmvJxK6LAxBo+lVlsksRLa1KV9LwRLXVjPx48tRaSEj8bcjlgxuh9e TpEOnYLUq1pv8P12GeItvsirwHHmw9Z28yP6Ow2wLYfToxlcwZGubWa7vep1BZX/Iva6hFmBloY3S cAJp3FtvfwoNhrm1nL+H/x/MzMP+xa88uJoKrRA1cjl7pFrR+bHehIVuE3hNYueA8o4P+ojZtw2dQ cry4rleaOT/6yD28thwpkRTKPDQCW0ub8QFtA2yPTKVTg2cbqtmCflPbiEKlIxwRY6rnkbyObSkP9 CBhd241jsYPtyQ==; In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 4 Jan 2024 17:27:53 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277316 Archived-At: > From: Mattias Engdegård > Date: Thu, 4 Jan 2024 17:27:53 +0100 > > It's the hash-table's turn to be subjected to some performance tuning. The implementation has changed very little over the years and it's not so much a matter of a single big thing to fix as many small ones, so the list of changes is fairly long but ever little helps. > > A working patch series can be found in the scratch/hash-table-perf branch. Although it should all be satisfactory and an improvement on what was before, there are a couple of details that I'd like to do better, which is why this hasn't been merged yet: the way shared hash_table_test structs are cached isn't very elegant, nor is the way we deal with Qunbound in pdumper.c. Thanks. Any data about the actual performance gains? Adding Stefan to the discussion, in case he has comments and suggestions.