From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Wed, 17 Jan 2024 05:31:24 +0200 Message-ID: <83r0igbppv.fsf@gnu.org> References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <20240104155642.B4A99C00344@vcs2.savannah.gnu.org> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@gutov.dev> <08314177-5AE9-4352-94A0-641830B4094D@gmail.com> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> <86cyu37elt.fsf@gmail.com> <83h6jeeq1z.fsf@gnu.org> <86mst5t00f.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68244@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 17 04:32:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rPwex-0000PP-VC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jan 2024 04:32:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPweo-00018b-Mt; Tue, 16 Jan 2024 22:32:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPwen-00018I-2o for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 22:32:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rPwem-0001i1-Qx for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 22:32:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rPwen-00014g-ID for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 22:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jan 2024 03:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.17054623043876 (code B ref 68244); Wed, 17 Jan 2024 03:32:01 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 17 Jan 2024 03:31:44 +0000 Original-Received: from localhost ([127.0.0.1]:50306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPweV-00010B-RY for submit@debbugs.gnu.org; Tue, 16 Jan 2024 22:31:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPweT-0000uU-Oo for 68244@debbugs.gnu.org; Tue, 16 Jan 2024 22:31:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPweN-0001eh-Lc; Tue, 16 Jan 2024 22:31:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IXiyTUR/NtzPebO12IBvUAqrNKhlG9Oc2FB+HZi2cE8=; b=KR1ASsj1rSl5LSPAc1+v ar5yrb4iyboQfJbGGXTRyGhbTD/Y5tyHBsEQ+RJw9KZ9jVqjF5ydlFHM0gCMWhttQ3dobP/7dua27 g0/rgGGZmNun+GfIEjIdRXOyUmmECH1z2hdjsuPgsSPickqCogvi2uG3J2XlWO5OH/45VQIf4JEso 0nwoLi30HbAibzufgGZW/CWWkPyD5mSpF3q2B4M5lDpwyhozRi4/IS5A0sZi2uqvTyM4oAwWltl2G uG6Kb1+ILuOh7Lia1wpce4AK98N23AEZjWGjyz9qAiHntpz9eT7l3zrW0iB/zgJu9m7J8O/Y8z7JL lrmItQ6EM+/SFQ==; In-Reply-To: <86mst5t00f.fsf@gmail.com> (message from Andy Moreton on Tue, 16 Jan 2024 21:57:04 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278373 Archived-At: > From: Andy Moreton > Date: Tue, 16 Jan 2024 21:57:04 +0000 > > On Mon 15 Jan 2024, Mattias Engdegård wrote: > > > 15 jan. 2024 kl. 13.31 skrev Eli Zaretskii : > > > >>> Bisect identifies this as the bad commit: > >>> d3cefd3e9835 ("Leaner hash table dumping and thawing") > > > > Thank you, I can reproduce the (or at least an) assertion failure in this > > commit. However it's probably a ghost error: although I've tried to make sure > > that there is a correct build at each point, there have been a lot of work > > going on rearranging things for correctness and clarity, and apparently I > > never built this particular one with checking enabled the last time. > > > > However this assertion should be removed by the next commit so the error is > > very short-lived (and it's just an over-zealous assertion, not an actual > > flaw). What problems do you observe when building master? > > > > (And yes, I should update some hashes in pdumper.c; it's been a while.) > > I bisected from newer master to get to that point. Bootstrapping master > commit f19f5604deb7 ("Update pdumper hashes for buffer and Lisp_Hash_Table") > is still failing, and trying to continue the buid by retrying after that > is glacially slow, so something is badly broken at that point. > > Note that the same commit bootstrapped after "git clean -xdf" still has > multiple backtraces when building without ENABLE_CHECKING. Can you show the first crash/assertion violation when building with ENABLE_CHECKING? It is important to see the error message, and if you can run the failing command under GDB and show a backtrace, it will be even more useful. Thanks.