From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Haojun Bao Newsgroups: gmane.emacs.devel Subject: Re: Willing to debug bug #3542 (23.0.94; File access via UNC path slow again under Windows) Date: Tue, 14 Jul 2009 12:31:31 +0800 Message-ID: <83prc3dgws.fsf@gmail.com> References: <7dbe73ed0907051401o26903ca3t9a67060f3a3417ad@mail.gmail.com> <83fxda1pef.fsf@gnu.org> <7dbe73ed0907060038w53699f77ie742996955ae8118@mail.gmail.com> <838wj11sz4.fsf@gnu.org> <83my7fz09s.fsf@gnu.org> <7dbe73ed0907081347q12dfd1a2lbbff915c49362f75@mail.gmail.com> <4A55D68D.8050407@gnu.org> <7dbe73ed0907090453s3e125b4ar142b90a268b105e2@mail.gmail.com> <7DAFC004A33C486A9E29A59689E7F02E@us.oracle.com> <4A5619F5.8010008@gnu.org> <8363e1zoak.fsf@gnu.org> <83hbxjrmue.fsf@gnu.org> <83ws6cqudb.fsf@gnu.org> <83tz1gqr33.fsf@gnu.org> <83prc4q7ef.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1247545900 19615 80.91.229.12 (14 Jul 2009 04:31:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jul 2009 04:31:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 14 06:31:33 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MQZfw-0002K5-LE for ged-emacs-devel@m.gmane.org; Tue, 14 Jul 2009 06:31:32 +0200 Original-Received: from localhost ([127.0.0.1]:41480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQZfv-0000NP-GU for ged-emacs-devel@m.gmane.org; Tue, 14 Jul 2009 00:31:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MQZfq-0000NK-Of for emacs-devel@gnu.org; Tue, 14 Jul 2009 00:31:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MQZfm-0000N0-92 for emacs-devel@gnu.org; Tue, 14 Jul 2009 00:31:26 -0400 Original-Received: from [199.232.76.173] (port=51294 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQZfm-0000Mx-2l for emacs-devel@gnu.org; Tue, 14 Jul 2009 00:31:22 -0400 Original-Received: from mail-px0-f193.google.com ([209.85.216.193]:51004) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MQZfl-0007xj-Mb for emacs-devel@gnu.org; Tue, 14 Jul 2009 00:31:21 -0400 Original-Received: by pxi31 with SMTP id 31so2118908pxi.14 for ; Mon, 13 Jul 2009 21:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=ODlNyKYCDRQq+3nImgP6qj/PnKE7iskzarI7hw4mYa0=; b=ONOFy8wZZ0HUgxQvZ/lER2B1Pu7TUoPamvia7iFYyEHKozu+j9pNkkKVybFywT4NMe RAzzFhAzWcfIbAqr9vTA2xP0UD9u/rxUePrsp+ZyxRbi2tqbOGhh6qaNzx20iUminho5 LL/A/85RD+Tj/7kKHqnQ5V4pQKVc74qS7hTRY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; b=am6Fvke4ogVOhXevVdPtekOw+aIS8MgJaJxVc+4/6VvK/VvgLcoxlGI5lyg2wIVGv+ AZXvizQrc1UJsTYf9geAkq6DmRmQJQabtzZoPJpFLf8XuNFhl8ZdZWLvHXlemCKdSBim CzuMkbNXzbsIsR4d8+qkiP93CrAQORbij3Vb4= Original-Received: by 10.114.158.1 with SMTP id g1mr10119368wae.18.1247545879996; Mon, 13 Jul 2009 21:31:19 -0700 (PDT) Original-Received: from bhj1.borqs.com ([122.200.68.238]) by mx.google.com with ESMTPS id m30sm9958063wag.69.2009.07.13.21.31.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 13 Jul 2009 21:31:18 -0700 (PDT) In-Reply-To: <83prc4q7ef.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Jul 2009 06:18:32 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.96 (cygwin) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112441 Archived-At: Eli Zaretskii <...> writes: >> From: Stefan Monnier >> Cc: Andreas Schwab , emacs-devel@gnu.org >> Date: Mon, 13 Jul 2009 20:54:14 -0400 >> >> > Aha. But it sounds like it's not just me who is confused. Here's >> > just two examples: >> >> > From doc.c: >> >> > strp = SDATA (string); >> > while (strp < SDATA (string) + SBYTES (string)) >> >> > (why not "while *strp"?) >> >> As said Andreas, this would stop at the first NUL, which may appear >> within the string. > > But then a gazillion other places are buggy: we _do_ use SDATA(str) as > a C string, and pass it to functions that will stop examining the > string on the first null. A random example: > > d = opendir (SDATA (Fdirectory_file_name (encoded_dir))); > > What am I missing? NUL can not be in a pathname, so it should be safe here to treat it as a classical C string.