From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redundant if clause in xdisp.c? Date: Sun, 30 Aug 2009 21:06:31 +0300 Message-ID: <83prad9nx4.fsf@gnu.org> References: <8363c6bxef.fsf@gnu.org> <834orqbjss.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1251655782 16172 80.91.229.12 (30 Aug 2009 18:09:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Aug 2009 18:09:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 30 20:09:35 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhoqM-0001LS-Kw for ged-emacs-devel@m.gmane.org; Sun, 30 Aug 2009 20:09:34 +0200 Original-Received: from localhost ([127.0.0.1]:33200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhoqM-0001oJ-06 for ged-emacs-devel@m.gmane.org; Sun, 30 Aug 2009 14:09:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mhopy-0001jN-7i for emacs-devel@gnu.org; Sun, 30 Aug 2009 14:09:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mhopx-0001ia-AX for emacs-devel@gnu.org; Sun, 30 Aug 2009 14:09:09 -0400 Original-Received: from [199.232.76.173] (port=33488 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mhopx-0001iW-7I for emacs-devel@gnu.org; Sun, 30 Aug 2009 14:09:09 -0400 Original-Received: from mtaout6.012.net.il ([84.95.2.16]:64318) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mhopw-0006Kx-PP for emacs-devel@gnu.org; Sun, 30 Aug 2009 14:09:09 -0400 Original-Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KP700H00BIZEQ00@i-mtaout6.012.net.il> for emacs-devel@gnu.org; Sun, 30 Aug 2009 21:08:35 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.228.144.38]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KP700BKYBQ9RUE0@i-mtaout6.012.net.il>; Sun, 30 Aug 2009 21:08:34 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114879 Archived-At: > From: Stefan Monnier > Date: Sat, 29 Aug 2009 17:21:42 -0400 > Cc: emacs-devel@gnu.org > > >> These optimizations seem to be pointless nowadays: even when running > >> Emacs-23 on my cell-phone (FreeRunner) displaying on my desktop, they > >> don't make any noticeable difference. > > > How did you turn them off to measure their influence, > > I removed the corresponding code. I think it's enough to set direction-reversed non-nil. > > and with what kind of stuff in your buffer(s)? > > I tried it in *scratch* and in a Python-mode buffer (visiting > /usr/bin/zhone), doing random movement and typing (especially using the > auto-repeat to see when the redisplay keeps up and when it doesn't). GUI session or tty? The price of disabling these optimizations might be more visible on a tty via a relatively slow link. I don't think we should remove them before we try at least that. > Sure, I just wanted to make sure you don't waste time in these parts of > the code. The first rule of optimization: don't do it. The second rule of optimization: don't do it yet. I'm somewhere before the first and the second one: I need to get the code work right before I make it faster (if needed).