From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Sun, 28 Feb 2010 21:31:21 +0200 Message-ID: <83pr3pb1iu.fsf@gnu.org> References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83vddidh73.fsf@gnu.org> <83hbp2cxgx.fsf@gnu.org> <87aauugy1g.fsf@stupidchicken.com> <83eik6co9l.fsf@gnu.org> <87mxyuyvxy.fsf@stupidchicken.com> <87fx4l8mkf.fsf@stupidchicken.com> <831vg5cll1.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1267385495 18677 80.91.229.12 (28 Feb 2010 19:31:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2010 19:31:35 +0000 (UTC) To: cyd@stupidchicken.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 28 20:31:26 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlorN-0001uL-PB for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2010 20:31:26 +0100 Original-Received: from localhost ([127.0.0.1]:54595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlorN-0007Gu-14 for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2010 14:31:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlorI-0007Gp-9S for emacs-devel@gnu.org; Sun, 28 Feb 2010 14:31:20 -0500 Original-Received: from [140.186.70.92] (port=58327 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlorF-0007Gh-Ni for emacs-devel@gnu.org; Sun, 28 Feb 2010 14:31:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NlorE-0000Xa-Rn for emacs-devel@gnu.org; Sun, 28 Feb 2010 14:31:17 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:47334) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlorE-0000XC-Ke for emacs-devel@gnu.org; Sun, 28 Feb 2010 14:31:16 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KYK00F00GQIVM00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sun, 28 Feb 2010 21:31:15 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.17.203]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYK00BO5GW0RVB0@a-mtaout20.012.net.il>; Sun, 28 Feb 2010 21:31:13 +0200 (IST) In-reply-to: <831vg5cll1.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121476 Archived-At: > Date: Sun, 28 Feb 2010 19:32:42 +0200 > From: Eli Zaretskii > Cc: schwab@linux-m68k.org, emacs-devel@gnu.org > > Well, unfortunately, it doesn't seem to solve the problem. I made the following experiment: . restore the calls to alloca -- the bug goes away . now add an xmalloc call to allocate a `struct charset_map_entries' right before alloca and an xfree call to free that memory after the call to load_charset_map, without doing anything with the allocated buffer in between the calls to xmalloc and to xfree -- the bug is back! So I think the change in charset.c itself did not cause the bug, it just exposed a bug elsewhere, because it reshuffles the heap.