From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 24 Feb 2012 22:04:08 +0200 Message-ID: <83pqd4roav.fsf@gnu.org> References: <87mx9su32g.fsf@web.de> <871uqzn3bc.fsf@gmx.de> <871uqz651u.fsf@gmx.de> <87pqd89lh4.fsf@gmail.com> <87mx8b3nvb.fsf@gmail.com> <87pqd6wnvv.fsf@gmail.com> <87d395y1w0.fsf@gmail.com> <87zkc8x04p.fsf@gmail.com> <87vcmwwvk7.fsf@gmail.com> <834nugtwqf.fsf@gnu.org> <87r4xkwhky.fsf@gmail.com> <83vcmws3bs.fsf@gnu.org> <87ehtkwaiz.fsf@gmail.com> <87wr7cgsm3.fsf@gmx.de> <8762eww77b.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1330113821 22426 80.91.229.3 (24 Feb 2012 20:03:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Feb 2012 20:03:41 +0000 (UTC) Cc: 10489@debbugs.gnu.org, michael.albinus@gmx.de To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 24 21:03:39 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S11Md-0000Uo-0I for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 21:03:35 +0100 Original-Received: from localhost ([::1]:34794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11Mc-0003DM-Hb for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 15:03:34 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11MZ-0003Be-Lc for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:03:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S11MV-0007Vx-K6 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:03:31 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11MV-0007Vt-G8 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:03:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S11Oz-00026G-Tt for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 15:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2012 20:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.13301139498051 (code B ref 10489); Fri, 24 Feb 2012 20:06:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 24 Feb 2012 20:05:49 +0000 Original-Received: from localhost ([127.0.0.1]:54569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S11Ol-00025n-TQ for submit@debbugs.gnu.org; Fri, 24 Feb 2012 15:05:48 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:56305) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S11Oh-00025Z-Pd for 10489@debbugs.gnu.org; Fri, 24 Feb 2012 15:05:44 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LZW00F00Y48NL00@a-mtaout23.012.net.il> for 10489@debbugs.gnu.org; Fri, 24 Feb 2012 22:03:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.12.178]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LZW00FB5YD1L290@a-mtaout23.012.net.il>; Fri, 24 Feb 2012 22:03:02 +0200 (IST) In-reply-to: <8762eww77b.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57194 Archived-At: > From: Thierry Volpiatto > Cc: Eli Zaretskii , 10489@debbugs.gnu.org > Date: Fri, 24 Feb 2012 17:02:16 +0100 > > (defun files-equal-p (file1 file2) > "Return non-nil if FILE1 and FILE2 name the same file." > (let ((handler (or (find-file-name-handler file1 'files-equal-p) > (find-file-name-handler file2 'files-equal-p)))) > (if handler > (funcall handler 'files-equal-p file1 file2) If FILE1 and FILE2 have different 'files-equal-p handlers, which one of them, if any, should be invoked here? IOW, shouldn't we invoke a file handler only if it can handle _both_ files? Also, if each file has a different handler, doesn't that in itself already mean the files are not equal? > (defun file-subdir-of-p (dir1 dir2) > "Return non-nil if DIR1 is a subdirectory of DIR2. > Note that a directory is treated by this function as a subdirectory of itself. > This function only works when its two arguments already exist, > when they don't, it returns nil." > (let ((handler (or (find-file-name-handler dir1 'file-subdir-of-p) > (find-file-name-handler dir2 'file-subdir-of-p)))) > (if handler > (funcalll handler 'file-subdir-of-p dir1 dir2) Same issue here. Except that, unlike in the files-equal-p case, it's not so clear what to do if each file has a different handler, or if one has a handler, but the other doesn't.