From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15045: Point jumps inappropriately around time of Semantic lexing Date: Mon, 14 Oct 2013 22:51:07 +0300 Message-ID: <83ppr7pr6c.fsf@gnu.org> References: <87pptptk9n.fsf@engster.org> <87eha4t7xz.fsf@engster.org> <8738qksz6l.fsf@engster.org> <837gfvua2r.fsf@gnu.org> <87y58bs9x4.fsf@engster.org> <83zjsrs3k2.fsf@gnu.org> <87pptmsv4z.fsf@engster.org> <83siyira0w.fsf@gnu.org> <87vc3drhuv.fsf@engster.org> <83haexrgjn.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1381780335 10672 80.91.229.3 (14 Oct 2013 19:52:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Oct 2013 19:52:15 +0000 (UTC) Cc: 15045@debbugs.gnu.org, deng@randomsample.de, eric@siege-engine.com To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 14 21:52:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VVoBb-0000bW-Tm for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2013 21:52:16 +0200 Original-Received: from localhost ([::1]:38493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVoBb-0001To-GX for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2013 15:52:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVoBT-0001TQ-CV for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 15:52:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVoBO-0007Dx-RC for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 15:52:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVoBO-0007Dr-NJ for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 15:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VVoBO-0004em-3v for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2013 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15045-submit@debbugs.gnu.org id=B15045.138178028217631 (code B ref 15045); Mon, 14 Oct 2013 19:52:02 +0000 Original-Received: (at 15045) by debbugs.gnu.org; 14 Oct 2013 19:51:22 +0000 Original-Received: from localhost ([127.0.0.1]:49305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVoAj-0004aD-FH for submit@debbugs.gnu.org; Mon, 14 Oct 2013 15:51:21 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:51950) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVoAg-0004ZF-4G for 15045@debbugs.gnu.org; Mon, 14 Oct 2013 15:51:19 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MUO00C00CB3MV00@a-mtaout23.012.net.il> for 15045@debbugs.gnu.org; Mon, 14 Oct 2013 22:51:11 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MUO00CKACHAJJ60@a-mtaout23.012.net.il>; Mon, 14 Oct 2013 22:51:11 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79248 Archived-At: > Date: Mon, 14 Oct 2013 15:32:40 -0400 > From: Barry OReilly > Cc: David Engster , Stefan Monnier , > 15045@debbugs.gnu.org, Eric Ludlam > > Given this has come up again separately in bug 15567, may I make the > change to input-pending-p? > > diff --git a/src/keyboard.c b/src/keyboard.c > index e0cd4d4..fdb7c7d 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -9962,8 +9962,7 @@ if there is a doubt, the value is t. */) > /* Process non-user-visible events (Bug#10195). */ > process_special_events (); > > - return (get_input_pending (READABLE_EVENTS_DO_TIMERS_NOW > - | READABLE_EVENTS_FILTER_EVENTS) > + return (get_input_pending (READABLE_EVENTS_FILTER_EVENTS) > ? Qt : Qnil); > } > > 'make check' passes. FWIW, I'm against such changes. You can never know how many places will be subtly broken by changes like that in such a popular interface. The original problem is rare enough, and should IMO be fixed in the code where it happens. Making changes like above on behalf of such marginal use cases is a tail wagging the dog. > Eli Zaretskii: > > What if input arrives because of a timer? > > If this is an issue, I propose input-pending-p return t if a timer is > ready to run. Likewise: too serious change in behavior for too obscure a reason.