From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: Stromeko@nexgo.de, 18405@debbugs.gnu.org
Subject: bug#18405: 24.3.93; bat-mode.el
Date: Tue, 09 Sep 2014 16:05:02 +0300 [thread overview]
Message-ID: <83ppf5aqrl.fsf@gnu.org> (raw)
In-Reply-To: <540D18D8.8070901@dancol.org>
> Date: Sun, 07 Sep 2014 19:47:52 -0700
> From: Daniel Colascione <dancol@dancol.org>
> CC: Stromeko@nexgo.de, 18405@debbugs.gnu.org
>
> > My point was that I saw a few of its aspects that might benefit from
> > improvements, and if we are going to add that package to Emacs, I'd
> > like to see those happen.
>
> Like what?
See below.
> In 2011, you just mentioned that we should be using or enhancing
> bat-generic-mode
My goodness, I hope you don't expect me to forever hold my peace about
this just because I happened to write something 3 years ago.
Here are my comments:
. There are some strange decisions about faces, for example:
. the switch letters in Unix-style -x switches are highlighted in
font-lock-type-face
. redirection characters are highlighted in font-lock-constant-face
. opening parenthesis in "echo" commands are given
font-lock-warning-face
. variable definitions in for loops (the 'x' part in "for %%x") are
highlighted with different face from their references in the "do"
part of the loop
. Text after "echo" (up to redirection character, if any) is always a
simple string, except if it's "on" or "off", but is not highlighted
as a string, which then causes some random highlighting of the
parts of the string that just happen to match other possible
syntaxes
. Something like this confuses fontification of the redirection
character, probably because of the parentheses (the opening paren
is given the font-lock-warning-face):
echo int main() >junk.c
. In general, I don't understand what was intended to be the handling
of parentheses, they seem to be either not highlighted at all or
given the warning face.
. A command of this form:
if exist somefile dosomethingwith somefile
has "dosomethingwith" sometimes in the font-lock-builtin-face and
sometimes with no face at all, not sure why. Looks like when
'somefile' includes slashes, the command is not fontified.
. The value to which a variable is set in "set foo-bar" doesn't have
any face, which causes some funny fontifications if that value
happens to match unrelated syntaxes, as in "set foo=-bar=baz"
. The equals sign in "if foo == bar" is sometimes given the
font-lock-keyword-face and sometimes no face at all. Here's one
example of the latter:
if not (%svgsupport%) == (Y) goto :svgDone
. This line has its fontifications after "(%distfiles%)" screwed:
for %%d in (%distfiles%) do if not exist %%d set fileNotFound=%%d
In particular, built-in commands are not fontified as such.
. Some built-in commands are missing from ntcmd-shell-builtins:
assoc, call, mklink
. "dir" and "rem" appear twice in the list in ntcmd-shell-builtins
. The support of "set /a" command is incomplete, e.g. try
set /a y+=140
Thanks.
next prev parent reply other threads:[~2014-09-09 13:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 18:44 bug#18405: 24.3.93; bat-mode.el Achim Gratz
2014-09-04 20:39 ` Stefan Monnier
2014-09-04 20:51 ` Achim Gratz
2014-09-05 7:03 ` Eli Zaretskii
2014-09-05 7:19 ` Eli Zaretskii
2014-09-05 18:39 ` Achim Gratz
2014-09-07 3:24 ` Daniel Colascione
2014-09-07 15:17 ` Eli Zaretskii
2014-09-08 1:04 ` Daniel Colascione
2014-09-08 2:42 ` Eli Zaretskii
2014-09-08 2:47 ` Daniel Colascione
2014-09-09 13:05 ` Eli Zaretskii [this message]
2014-09-09 13:45 ` Stefan Monnier
2014-09-09 14:40 ` Eli Zaretskii
2014-09-08 7:32 ` Achim Gratz
-- strict thread matches above, loose matches on Subject: below --
2017-08-31 19:06 bug#28311: 25.2; Improve syntax highlighting in bat-mode Anders Lindgren
2017-08-31 19:27 ` Achim Gratz
2017-09-22 13:43 ` Eli Zaretskii
2017-09-22 17:01 ` bug#18405: " Glenn Morris
2017-09-22 19:04 ` Anders Lindgren
2017-09-22 19:14 ` Eli Zaretskii
2017-09-23 12:50 ` Anders Lindgren
2017-09-23 13:09 ` Eli Zaretskii
2017-09-23 18:05 ` bug#18405: " Anders Lindgren
2017-09-23 18:17 ` Eli Zaretskii
2022-04-24 13:24 ` bug#18405: 24.3.93; bat-mode.el Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ppf5aqrl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18405@debbugs.gnu.org \
--cc=Stromeko@nexgo.de \
--cc=dancol@dancol.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.