From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18528: 24.3.93; Crash during restoration of frameset from desktop Date: Wed, 24 Sep 2014 10:15:48 +0300 Message-ID: <83ppelwkt7.fsf@gnu.org> References: <83egv3y90k.fsf@gnu.org> <54205FCF.4050503@gmx.at> <83bnq7y13y.fsf@gnu.org> <542109B8.6080107@gmx.at> <8361gexsrg.fsf@gnu.org> <54219CB5.6080103@gmx.at> <83zjdqw4y9.fsf@gnu.org> <5421C72E.7080405@gmx.at> <83vboew2vk.fsf@gnu.org> <83tx3yw2bw.fsf@gnu.org> <542261CF.2080709@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1411542991 9963 80.91.229.3 (24 Sep 2014 07:16:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Sep 2014 07:16:31 +0000 (UTC) Cc: 18528@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 24 09:16:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XWgoI-0008NS-2n for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Sep 2014 09:16:22 +0200 Original-Received: from localhost ([::1]:57873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWgoH-0007XT-J5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Sep 2014 03:16:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWgo9-0007XM-MU for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 03:16:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWgo4-000447-GV for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 03:16:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWgo4-00043n-DC for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 03:16:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XWgny-0003AB-O7 for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Sep 2014 07:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18528 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18528-submit@debbugs.gnu.org id=B18528.141154295812147 (code B ref 18528); Wed, 24 Sep 2014 07:16:02 +0000 Original-Received: (at 18528) by debbugs.gnu.org; 24 Sep 2014 07:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:50417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWgnt-00039q-Pj for submit@debbugs.gnu.org; Wed, 24 Sep 2014 03:15:58 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:35841) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWgnq-00039f-5y for 18528@debbugs.gnu.org; Wed, 24 Sep 2014 03:15:55 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NCE0040097XTN00@mtaout25.012.net.il> for 18528@debbugs.gnu.org; Wed, 24 Sep 2014 10:10:54 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCE003CD9A6JD10@mtaout25.012.net.il>; Wed, 24 Sep 2014 10:10:54 +0300 (IDT) In-reply-to: <542261CF.2080709@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93674 Archived-At: > Date: Wed, 24 Sep 2014 08:16:47 +0200 > From: martin rudalics > CC: 18528@debbugs.gnu.org > > > So now I don't understand why you asked about rounding up, since we > > evidently already do. > > Not everywhere. For example, we don't in FRAME_MESSAGE_BUF_SIZE and > FRAME_CURSOR_X_LIMIT. And the following check in compute_motion of > indent.c seems dubious as well. > > if (!NILP (Vtruncate_partial_width_windows) > && (total_width < FRAME_COLS (XFRAME (WINDOW_FRAME (win))))) That has nothing to do with rounding, does it? Anyway, FRAME_MESSAGE_BUF_SIZE has nothing to do with frame/window width, AFAIR, it is just computed based on the width. FRAME_CURSOR_X_LIMIT is used only for the echo area, so the probability of having a non-default font there is very low. We should probably do that calculation in pixels, though. As for the second example, I have a difficulty concocting a use case when it should matter, due to a combination of conditions that enter that block. But feel free to fix that if it sometimes gives bad results.