From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trunk broken on MS-Windows Date: Sat, 08 Nov 2014 22:40:52 +0200 Message-ID: <83ppcxpgrv.fsf@gnu.org> References: <83tx29pine.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1415479294 9217 80.91.229.3 (8 Nov 2014 20:41:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Nov 2014 20:41:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: dmoncayo@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 08 21:41:27 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XnCp3-00037Q-Nc for ged-emacs-devel@m.gmane.org; Sat, 08 Nov 2014 21:41:25 +0100 Original-Received: from localhost ([::1]:36807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnCp3-0007GT-6M for ged-emacs-devel@m.gmane.org; Sat, 08 Nov 2014 15:41:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnCos-0007FT-UP for emacs-devel@gnu.org; Sat, 08 Nov 2014 15:41:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnCon-0004fr-18 for emacs-devel@gnu.org; Sat, 08 Nov 2014 15:41:14 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:45965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnCom-0004fl-PL for emacs-devel@gnu.org; Sat, 08 Nov 2014 15:41:08 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NEQ00F00MA3HB00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sat, 08 Nov 2014 22:41:07 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEQ00FIIMSICI60@a-mtaout21.012.net.il>; Sat, 08 Nov 2014 22:41:07 +0200 (IST) In-reply-to: <83tx29pine.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176588 Archived-At: > Date: Sat, 08 Nov 2014 22:00:21 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > The build fails with these error messages: > > Warning: arch-independent data dir `%emacs_dir%/share/emacs/25.0.50/etc/': Permission denied > Warning: Lisp directory `./lisp': No such file or directory > Error: charsets directory not found: > d:/gnu/bzr/emacs/trunk/src/%emacs_dir%/share/emacs/25.0.50/etc/charsets > Emacs will not function correctly without the character map files. > Please check your installation! > Makefile:833: recipe for target `bootstrap-emacs.exe' failed > make[1]: *** [bootstrap-emacs.exe] Error 1 > > Looks like some fallout from commits in r118316..118318. The problem is with editing nt/epaths.nt into src/epaths.in, and specifically with editing of @SRC@. Instead of substituting the absolute file name of the top-level directory, Makefile now substitutes just ".", so we end up with #define PATH_DUMPLOADSEARCH "./lisp" instead of the correct #define PATH_DUMPLOADSEARCH "d:/foo/bar/baz/lisp" This makes this portion of init_callproc fail: if (data_dir == 0) { Lisp_Object tem, tem1, srcdir; Lisp_Object lispdir = Fcar (decode_env_path (0, PATH_DUMPLOADSEARCH, 0)); srcdir = Fexpand_file_name (build_string ("../src/"), lispdir); tem = Fexpand_file_name (build_string ("NEWS"), Vdata_directory); tem1 = Ffile_exists_p (tem); if (!NILP (Fequal (srcdir, Vinvocation_directory)) || NILP (tem1)) { Lisp_Object newdir; newdir = Fexpand_file_name (build_string ("../etc/"), lispdir); tem = Fexpand_file_name (build_string ("NEWS"), newdir); tem1 = Ffile_exists_p (tem); if (!NILP (tem1)) Vdata_directory = newdir; } } because when lispdir is just "./lisp", expand-file-name yields d:/foo/bar/baz/src/src, since it expands "." into the directory where temacs runs. IOW, the new editing of epaths.h will probably fail for anyone who builds inside the source tree.