From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Date: Wed, 25 Feb 2015 19:43:52 +0200 Message-ID: <83pp8x6g4n.fsf@gnu.org> References: <87pp953q1j.fsf_-_@violet.siamics.net> <83lhjslwup.fsf@gnu.org> <87h9ug4dk1.fsf@violet.siamics.net> <87d25447e8.fsf@violet.siamics.net> <874mqf4ixf.fsf@violet.siamics.net> <83lhjrcwy6.fsf@gnu.org> <87sidu3423.fsf@violet.siamics.net> <83vbiq561x.fsf@gnu.org> <87egpd3oju.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1424886261 30615 80.91.229.3 (25 Feb 2015 17:44:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2015 17:44:21 +0000 (UTC) Cc: 19903@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 18:44:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQg0I-00008I-OG for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 18:44:10 +0100 Original-Received: from localhost ([::1]:55614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQg0I-00028V-AJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 12:44:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQg0F-00025p-1o for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:44:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQg0A-0002E2-Ux for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:44:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQg0A-0002Dy-SF for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YQg0A-0007k6-Hn for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 12:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Feb 2015 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19903 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19903-submit@debbugs.gnu.org id=B19903.142488623129737 (code B ref 19903); Wed, 25 Feb 2015 17:44:02 +0000 Original-Received: (at 19903) by debbugs.gnu.org; 25 Feb 2015 17:43:51 +0000 Original-Received: from localhost ([127.0.0.1]:58033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQfzy-0007jZ-Ob for submit@debbugs.gnu.org; Wed, 25 Feb 2015 12:43:51 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:63738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQfzv-0007jL-W8 for 19903@debbugs.gnu.org; Wed, 25 Feb 2015 12:43:49 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKC00E008X45100@a-mtaout20.012.net.il> for 19903@debbugs.gnu.org; Wed, 25 Feb 2015 19:43:40 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKC00DCT98SWX90@a-mtaout20.012.net.il>; Wed, 25 Feb 2015 19:43:40 +0200 (IST) In-reply-to: <87egpd3oju.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99814 Archived-At: > From: Ivan Shmakov > Date: Wed, 25 Feb 2015 17:10:13 +0000 > > >>>>> Eli Zaretskii writes: > >>>>> From: Ivan Shmakov Date: Wed, 25 Feb 2015 06:20:36 +0000 > > >>> I don't think internal functions should cater to UI issues, unless > >>> they are themselves interactive. > > >> I’m unsure where you see an UI issue here? The issue, as originally > >> reported, is that face-attribute fails to handle string-named faces, > >> which are considered perfectly valid by the rest of Emacs > >> (including, say, facep and the display engine.) > > > Accepting strings instead of symbols is a convenience feature > > for users, so it's a UI issue. > > Could you please elaborate on this? Specifically, does this > apply to the interactive or non-interactive use (or both) of > facemenu-add-face? Both. > >>> If we keep this confined to interactive functions, how many such > >>> functions in facemenu.el will have to be changed? If not too many, > >>> I'm inclined to keep this there. > > >> I believe that facemenu-add-face is the only function which can be > >> used to add a string-named face /interactively/, as it reads an > >> arbitrary Lisp form for the face. (See also #18369.) > > > Yes, but how many don't? > > One another (facemenu-set-face) uses read-face-name, which in > turn explicitly passes user input through ‘intern’. > > Then, facemenu-set-face-from-menu uses last-command-event (when > called interactively), assumes it’s a symbol, and uses it either > as a face directly /or/ (should its name begin with fg: or bg:) > as the cdr for a cons cell face. (The facemenu-set-foreground > and facemenu-set-background commands rely on this.) > > Per my reading of the code, no other command there accepts > user-specified faces when used interactively. So only one function needs a change? If so, I think that's what we should do.