From: Eli Zaretskii <eliz@gnu.org>
To: Nicolas Richard <youngfrog@members.fsf.org>
Cc: 20734@debbugs.gnu.org
Subject: bug#20734: 25.0.50; "Args out of range" with help-window-select t
Date: Fri, 05 Jun 2015 22:56:16 +0300 [thread overview]
Message-ID: <83pp5and3z.fsf@gnu.org> (raw)
In-Reply-To: <866172rl5z.fsf@members.fsf.org>
> From: Nicolas Richard <youngfrog@members.fsf.org>
> Cc: 20734@debbugs.gnu.org
> Date: Fri, 05 Jun 2015 21:48:40 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
> > Yes, that's the bug. But the real problem is that we've switched
> > windows temporarily, and we shouldn't move point in the current buffer
> > at all when we do that.
>
> Ok. I think I understand now. What about adding an assertion to make
> sure current_buffer is shown in selected_window at that point?
That'd be fine with me.
> > I think we shouldn't call adjust_point_for_property in this case
> > at all. Can you see if adding
> >
> > && EQ (XWINDOW (selected_window)->contents, current_buffer)
> >
> > to the condition that guards the call to adjust_point_for_property
> > fixes the problem?
>
> Yes it does, but I wrapped the lhs into XBUFFER :
>
> && EQ (XBUFFER (XWINDOW (selected_window)->contents), current_buffer)
Sorry, my bad. But in that case, you don't need EQ, just use == to
compare 2 C pointers.
next prev parent reply other threads:[~2015-06-05 19:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 19:47 bug#20734: 25.0.50; "Args out of range" with help-window-select t Nicolas Richard
2015-06-04 22:27 ` Stefan Monnier
2015-06-05 9:33 ` Nicolas Richard
2015-06-05 13:46 ` Eli Zaretskii
2015-06-05 6:41 ` Eli Zaretskii
2015-06-05 9:25 ` Nicolas Richard
2015-06-05 13:45 ` Eli Zaretskii
2015-06-05 19:48 ` Nicolas Richard
2015-06-05 19:56 ` Eli Zaretskii [this message]
2015-06-06 8:44 ` Nicolas Richard
2015-06-06 8:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pp5and3z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20734@debbugs.gnu.org \
--cc=youngfrog@members.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.