all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: eggert@cs.ucla.edu, Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Re: Master is broken
Date: Sat, 10 Oct 2015 13:46:34 +0300	[thread overview]
Message-ID: <83pp0nrofp.fsf@gnu.org> (raw)
In-Reply-To: <838u7bt8id.fsf@gnu.org>

> Date: Sat, 10 Oct 2015 11:47:38 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
>   data.o: In function `Fsetcdr':
>   /srv/data/home/e/eliz/git/emacs/trunk/src/data.c:573: undefined reference to `CHECK_IMPURE'
>   data.o:/srv/data/home/e/eliz/git/emacs/trunk/src/data.c:2218: more undefined references to `CHECK_IMPURE' follow
>   collect2: error: ld returned 1 exit status
>   make[1]: *** [temacs] Error 1
> 
> I'm not really sure what's going on here, all this INLINE stuff is too
> complicated.  These 2 inline functions are clearly visible in the
> preprocessed source, and still the linker barfs.  The only way I could
> make it link successfully was by including puresize.h in emacs.c as
> well, but then temacs crashed during loadup.

With the fix by Andreas in 8f41c30, including puresize.h in emacs.c
now seems to DTRT, so I committed that change.

Btw, Andreas, don't we need a similar change (i.e. use XPNTR in the
second argument of CHECK_IMPURE) in the other places where
CHECK_IMPURE is called as well?  If not, can you explain why XVECTOR
is incorrect there, but XCONS is correct?

Thanks.



  parent reply	other threads:[~2015-10-10 10:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10  8:47 Master is broken Eli Zaretskii
2015-10-10 10:44 ` Andy Moreton
2015-10-10 10:54   ` Eli Zaretskii
2015-10-10 11:27     ` Andy Moreton
2015-10-10 10:46 ` Eli Zaretskii [this message]
2015-10-10 15:59   ` Andreas Schwab
2015-10-10 16:19     ` Eli Zaretskii
2015-10-10 16:46   ` Paul Eggert
2015-10-10 17:06     ` Eli Zaretskii
2015-10-10 17:12       ` Eli Zaretskii
2015-10-10 19:01         ` Paul Eggert
2015-10-10 19:05           ` Eli Zaretskii
2015-10-10 19:31             ` Paul Eggert
2015-10-11  0:13           ` Juanma Barranquero
2015-10-11  0:32             ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pp0nrofp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.