From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: aurelien.aptel+emacs@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: More over-engineering
Date: Mon, 30 Nov 2015 22:04:51 +0200 [thread overview]
Message-ID: <83poyrl0d8.fsf@gnu.org> (raw)
In-Reply-To: <jwvwpszqo0b.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 30 Nov 2015 14:40:02 -0500
> Cc: Aurélien Aptel <aurelien.aptel+emacs@gmail.com>,
> Emacs development discussions <emacs-devel@gnu.org>
>
> > I agree. Although I'm a fan of --with-wide-int, I don't think it should
> > force this extra complication in modules.
>
> I managed to make it work for --with-wide-int without having to
> re-compile the modules (those rare 64bit values which can't be crammed
> into 32bit go through an extra proxy object).
I get compilation warnings with those changes:
emacs-module.c: In function 'value_to_lisp':
emacs-module.c:853:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
EMACS_INT tmp = (EMACS_INT)v;
^
emacs-module.c:859:7: warning: passing argument 1 of 'make_lisp_ptr' makes pointer from integer without a cast [enabled by default]
o = make_lisp_ptr ((tmp - tag) >> GCTYPEBITS, tag); break;
^
In file included from emacs-module.c:30:0:
lisp.h:1095:1: note: expected 'void *' but argument is of type 'EMACS_INT'
make_lisp_ptr (void *ptr, enum Lisp_Type type)
^
emacs-module.c:861:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
o = make_lisp_ptr ((void*)(tmp - tag), tag);
^
emacs-module.c: In function 'lisp_to_value':
emacs-module.c:895:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
if (val == (EMACS_UINT)(emacs_value)val)
^
emacs-module.c:895:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
if (val == (EMACS_UINT)(emacs_value)val)
^
emacs-module.c:897:29: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
emacs_value v = (emacs_value) ((val << GCTYPEBITS) | tag);
^
emacs-module.c:907:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
if (((EMACS_UINT)ptr) & ((1 << GCTYPEBITS) - 1))
^
emacs-module.c:913:40: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
emacs_value v = (emacs_value)(((EMACS_UINT) ptr) | tag);
^
emacs-module.c:913:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
emacs_value v = (emacs_value)(((EMACS_UINT) ptr) | tag);
^
next prev parent reply other threads:[~2015-11-30 20:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 17:00 More over-engineering Stefan Monnier
2015-11-27 17:12 ` Aurélien Aptel
2015-11-27 17:37 ` David Kastrup
2015-11-27 18:02 ` Stefan Monnier
2015-11-27 18:19 ` Eli Zaretskii
2015-11-27 18:53 ` Stefan Monnier
2015-11-27 19:32 ` Eli Zaretskii
2015-11-27 21:55 ` Stefan Monnier
2015-11-28 7:51 ` Eli Zaretskii
2015-11-28 16:22 ` Stefan Monnier
2015-11-28 16:34 ` Eli Zaretskii
2015-11-28 23:13 ` Paul Eggert
2015-11-30 19:40 ` Stefan Monnier
2015-11-30 20:04 ` Eli Zaretskii [this message]
2015-11-30 20:39 ` Stefan Monnier
2015-11-30 20:49 ` Eli Zaretskii
2015-12-06 21:16 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83poyrl0d8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.