* Re: [Emacs-diffs] emacs-25 035bd81: Update documentation for Dired search and replace
[not found] ` <E1aMs4r-0004lR-Mj@vcs.savannah.gnu.org>
@ 2016-01-23 7:10 ` Dmitry Gutov
2016-01-23 8:07 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2016-01-23 7:10 UTC (permalink / raw)
To: emacs-devel, Eli Zaretskii
On 01/23/2016 09:53 AM, Eli Zaretskii wrote:
> branch: emacs-25
> commit 035bd8159fe5bcea15eacc8a23ab54f4bc3b6f17
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> Update documentation for Dired search and replace
>
> * doc/emacs/dired.texi (Operating on Files): Update descriptions
> of 'A' and 'Q' now bound to 'dired-do-find-regexp' and
> 'dired-do-find-regexp-and-replace'.
>
> * etc/NEWS: Mention xref-related changes in Dired.
Looks good overall, thanks.
> +(@code{dired-do-find-regexp}).
> +This command is a variant of @code{xref-find-apropos}
> +(@pxref{Identifier Search}), it displays the @file{*xref*} buffer,
> +where you can navigate between matches and display them as needed
> +using the commands described in @ref{Xref Commands}.
That's rather wrong: dired-do-find-regexp performs regexp-search inside
the files.
xref-find-apropos, on the other hand, performs regexp search inside the
definitions index (obarray for elisp backend, and TAGS file for etags
backend).
Although I get that you might want to avoid mentioning
project-find-regexp here, and there's no other suitable command to
compare to.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-25 035bd81: Update documentation for Dired search and replace
2016-01-23 7:10 ` [Emacs-diffs] emacs-25 035bd81: Update documentation for Dired search and replace Dmitry Gutov
@ 2016-01-23 8:07 ` Eli Zaretskii
2016-01-23 8:10 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2016-01-23 8:07 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 23 Jan 2016 10:10:12 +0300
>
> > +This command is a variant of @code{xref-find-apropos}
> > +(@pxref{Identifier Search}), it displays the @file{*xref*} buffer,
> > +where you can navigate between matches and display them as needed
> > +using the commands described in @ref{Xref Commands}.
>
> That's rather wrong: dired-do-find-regexp performs regexp-search inside
> the files.
>
> xref-find-apropos, on the other hand, performs regexp search inside the
> definitions index (obarray for elisp backend, and TAGS file for etags
> backend).
Would "similar to" still bug you?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-25 035bd81: Update documentation for Dired search and replace
2016-01-23 8:07 ` Eli Zaretskii
@ 2016-01-23 8:10 ` Dmitry Gutov
2016-01-23 11:47 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2016-01-23 8:10 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On 01/23/2016 11:07 AM, Eli Zaretskii wrote:
> Would "similar to" still bug you?
I think calling it "a variant of" or "similar to" xref-find-references
instead would be better.
The decision is up to you, it's not too big a problem either way.
I'd just like to add that xref-query-replace works in
dired-do-find-regexp output, but doesn't work in xref-find-apropos output.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-25 035bd81: Update documentation for Dired search and replace
2016-01-23 8:10 ` Dmitry Gutov
@ 2016-01-23 11:47 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2016-01-23 11:47 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 23 Jan 2016 11:10:35 +0300
>
> On 01/23/2016 11:07 AM, Eli Zaretskii wrote:
>
> > Would "similar to" still bug you?
>
> I think calling it "a variant of" or "similar to" xref-find-references
> instead would be better.
Done.
> I'd just like to add that xref-query-replace works in
> dired-do-find-regexp output, but doesn't work in xref-find-apropos output.
Yes, I know. I decided to disregard that subtlety in this case.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-23 11:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160123065341.18279.32482@vcs.savannah.gnu.org>
[not found] ` <E1aMs4r-0004lR-Mj@vcs.savannah.gnu.org>
2016-01-23 7:10 ` [Emacs-diffs] emacs-25 035bd81: Update documentation for Dired search and replace Dmitry Gutov
2016-01-23 8:07 ` Eli Zaretskii
2016-01-23 8:10 ` Dmitry Gutov
2016-01-23 11:47 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.