From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 10597c9: Don't use 'find-program' Date: Sat, 16 Apr 2016 14:57:28 +0300 Message-ID: <83potpbwbb.fsf@gnu.org> References: <20160411164301.22548.38008@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460807882 2740 80.91.229.3 (16 Apr 2016 11:58:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Apr 2016 11:58:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 16 13:57:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arOrN-0007s8-P0 for ged-emacs-devel@m.gmane.org; Sat, 16 Apr 2016 13:57:57 +0200 Original-Received: from localhost ([::1]:54200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arOrN-0006ZK-2j for ged-emacs-devel@m.gmane.org; Sat, 16 Apr 2016 07:57:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arOrJ-0006TD-6E for emacs-devel@gnu.org; Sat, 16 Apr 2016 07:57:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arOrE-0007J9-5w for emacs-devel@gnu.org; Sat, 16 Apr 2016 07:57:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arOrE-0007J5-2g for emacs-devel@gnu.org; Sat, 16 Apr 2016 07:57:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3545 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1arOrD-0000lu-5b; Sat, 16 Apr 2016 07:57:47 -0400 In-reply-to: (message from Glenn Morris on Mon, 11 Apr 2016 17:56:42 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202987 Archived-At: > From: Glenn Morris > Cc: Eli Zaretskii > Date: Mon, 11 Apr 2016 17:56:42 -0400 > > > If you use grep, :), you'll see that "find-program" is used in other > files as well (find-dired, check-declare, find-cmd). > > (Personally I think renaming it to grep-find-program was a too-literal > adherence to the namespace convention. It is the find program, it just > happened to live in grep.el. Its general usefulness is reflected in the > autoload. Maybe you'd be happier moving it to some find*.el file.) check-declare uses find/grep, so I changed it to use grep-find-program. I don't know what to do about the other 2 cases. It is certainly wrong for them to use the same defcustom as used in grep.el and related commands. I think they should be changed to use a separate defcustom (which could be called find-program ;-). But I leave this to whoever cares enough to scratch that itch.