all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-25 10597c9: Don't use 'find-program'
Date: Sat, 16 Apr 2016 14:57:28 +0300	[thread overview]
Message-ID: <83potpbwbb.fsf@gnu.org> (raw)
In-Reply-To: <ejtwj7ajxh.fsf@fencepost.gnu.org> (message from Glenn Morris on Mon, 11 Apr 2016 17:56:42 -0400)

> From: Glenn Morris <rgm@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 11 Apr 2016 17:56:42 -0400
> 
> 
> If you use grep, :), you'll see that "find-program" is used in other
> files as well (find-dired, check-declare, find-cmd).
> 
> (Personally I think renaming it to grep-find-program was a too-literal
> adherence to the namespace convention. It is the find program, it just
> happened to live in grep.el. Its general usefulness is reflected in the
> autoload. Maybe you'd be happier moving it to some find*.el file.)

check-declare uses find/grep, so I changed it to use
grep-find-program.

I don't know what to do about the other 2 cases.  It is certainly
wrong for them to use the same defcustom as used in grep.el and
related commands.  I think they should be changed to use a separate
defcustom (which could be called find-program ;-).  But I leave this
to whoever cares enough to scratch that itch.



  parent reply	other threads:[~2016-04-16 11:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160411164301.22548.38008@vcs.savannah.gnu.org>
     [not found] ` <E1apevV-0005sL-3G@vcs.savannah.gnu.org>
2016-04-11 21:56   ` emacs-25 10597c9: Don't use 'find-program' Glenn Morris
2016-04-11 22:00     ` Drew Adams
2016-04-12  2:29       ` Eli Zaretskii
2016-04-16 11:57     ` Eli Zaretskii [this message]
2016-04-16 17:40       ` Glenn Morris
2016-04-16 18:57         ` Eli Zaretskii
2016-04-17 17:15           ` Glenn Morris
2016-04-17 17:39             ` Eli Zaretskii
2016-04-18  4:39               ` Paul Eggert
2016-04-18 18:25                 ` Eli Zaretskii
2016-04-18 16:10               ` Glenn Morris
2016-04-18 16:16                 ` Glenn Morris
2016-04-18 18:47                   ` Eli Zaretskii
2016-04-18 16:50                 ` Glenn Morris
2016-04-18 18:50                   ` Eli Zaretskii
2016-04-20 19:07                     ` Glenn Morris
2016-04-20 19:24                       ` Eli Zaretskii
2016-04-20 19:30                         ` Stefan Monnier
2016-04-20 19:40                           ` Eli Zaretskii
2016-04-20 20:08                             ` Stefan Monnier
2016-04-20 22:54                               ` John Wiegley
2016-04-18 18:45                 ` Eli Zaretskii
2016-04-20 19:27               ` Dmitry Gutov
2016-04-20 19:37                 ` Eli Zaretskii
2016-04-20 19:59                   ` Stefan Monnier
2016-04-20 20:06                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83potpbwbb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.