From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24378: [PATCH 1/6] =?UTF-8?Q?Don=E2=80=99t?= use FETCH_MULTIBYTE_CHAR when advancing index Date: Tue, 06 Sep 2016 17:43:48 +0300 Message-ID: <83poohay1n.fsf@gnu.org> References: <1473168498-13194-1-git-send-email-mina86@mina86.com> <1473168694-13605-1-git-send-email-mina86@mina86.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473173537 992 195.159.176.226 (6 Sep 2016 14:52:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2016 14:52:17 +0000 (UTC) Cc: 24378@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 16:52:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhHjJ-0007fo-8j for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 16:52:05 +0200 Original-Received: from localhost ([::1]:34108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhHjK-0002YG-5N for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 10:52:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhHcY-0004ho-OS for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 10:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhHcU-0001x3-G1 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 10:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhHcU-0001wz-C7 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 10:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bhHcU-0007o7-3k for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 10:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2016 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24378-submit@debbugs.gnu.org id=B24378.147317305029936 (code B ref 24378); Tue, 06 Sep 2016 14:45:02 +0000 Original-Received: (at 24378) by debbugs.gnu.org; 6 Sep 2016 14:44:10 +0000 Original-Received: from localhost ([127.0.0.1]:51418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhHbe-0007mm-MK for submit@debbugs.gnu.org; Tue, 06 Sep 2016 10:44:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhHbd-0007mZ-9W for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 10:44:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhHbU-0001kO-TZ for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 10:44:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhHbU-0001k4-Q0; Tue, 06 Sep 2016 10:44:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bhHbS-0004Fx-Sb; Tue, 06 Sep 2016 10:43:59 -0400 In-reply-to: <1473168694-13605-1-git-send-email-mina86@mina86.com> (message from Michal Nazarewicz on Tue, 6 Sep 2016 15:31:29 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122994 Archived-At: > From: Michal Nazarewicz > Date: Tue, 6 Sep 2016 15:31:29 +0200 > > * src/casefiddle.c (casify_region): use STRING_CHAR_AND_LENGTH as a safe > alternative to FETCH_MULTIBYTE_CHAR which is documented in src/buffer.h > as unsafe when used for advancing index. AFAIK, that comment is stale and no longer correct. I don't think there's a reason to make this change anymore, since STRING_CHAR no longer unifies characters. Thanks.