all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: p.stephani2@gmail.com
Cc: 24372-done@debbugs.gnu.org
Subject: bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point
Date: Fri, 23 Sep 2016 17:28:22 +0300	[thread overview]
Message-ID: <83ponud721.fsf@gnu.org> (raw)
In-Reply-To: <83twdm9re9.fsf@gnu.org> (message from Eli Zaretskii on Sun, 11 Sep 2016 22:18:38 +0300)

> Date: Sun, 11 Sep 2016 22:18:38 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 24372@debbugs.gnu.org
> 
> >  How about a variant of this below? It uses a fixed limitation from
> >  below on the delay, but only for the first blink. (The value 0.2 was
> >  found by experimentation, not sure if we need to add yet another
> >  defcustom for that.)
> > 
> > I don't think we should introduce magic numbers or further customization options.
> 
> It solves the problem, doesn't it?  I don't mind very much if it were
> a defcustom, I just think no one would want to change it.
> 
> >  > I've attached another patch with the change I have in mind.
> > 
> >  This has a disadvantage of creating a new timer object each time,
> >  which I think we'd like to avoid: too much consing. (Also, don't you
> >  need to set the timer variable to nil when the timer is disabled?)
> > 
> > I don't understand - the patch doesn't create any additional timers, it only changes the initial delay of the
> > idle-timer.
> 
> Each time blink-cursor--start-timer or blink-cursor--start-idle-timer
> is called, they create a new timer, right?  And your patch makes us
> call these functions each time blinking is started or ended, right?
> 
> > My patch is identical, except is uses blink-cursor-interval as lower bound. 
> 
> Of course.  That's why I said it's a minor variant.
> 
> There's another difference, though: in my patch we only limit the
> first argument to run-with-timer/run-with-idle-timer, not the second.
> So only the first blink cycle is affected.

No further comments, so I pushed my last proposed patch to the
emacs-25 branch, and I'm marking this bug done.

Thanks.





  reply	other threads:[~2016-09-23 14:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 19:16 bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point Philipp Stephani
2016-09-05 21:29 ` Clément Pit--Claudel
2016-09-06 16:03 ` Eli Zaretskii
2016-09-09 15:59   ` Philipp Stephani
2016-09-09 16:07     ` Eli Zaretskii
2016-09-09 16:20       ` Philipp Stephani
2016-09-09 16:29         ` Philipp Stephani
2016-09-09 17:18           ` Philipp Stephani
2016-09-09 18:59             ` Philipp Stephani
2016-09-10  7:21             ` Eli Zaretskii
2016-09-11  9:15               ` Philipp Stephani
2016-09-11 16:23                 ` Eli Zaretskii
2016-09-11 17:37                   ` Philipp Stephani
2016-09-11 19:18                     ` Eli Zaretskii
2016-09-23 14:28                       ` Eli Zaretskii [this message]
2016-09-25 19:09                       ` Philipp Stephani
2016-10-01  8:25                         ` Eli Zaretskii
2016-10-01 16:11                           ` Philipp Stephani
2016-10-01 17:29                             ` Eli Zaretskii
2016-10-01 18:10                               ` Philipp Stephani
2016-10-02  7:12                                 ` Eli Zaretskii
2016-10-01 18:16                             ` Philipp Stephani
2016-10-02  7:14                               ` Eli Zaretskii
2016-10-02 17:56                                 ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ponud721.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24372-done@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.