From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25025: python-shell-calculate-command is wrong Date: Fri, 25 Nov 2016 10:32:31 +0200 Message-ID: <83polk3qow.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1480062796 1290 195.159.176.226 (25 Nov 2016 08:33:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 25 Nov 2016 08:33:16 +0000 (UTC) Cc: 25025@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 25 09:33:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cABwS-0007Pi-9N for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Nov 2016 09:33:08 +0100 Original-Received: from localhost ([::1]:44629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cABwV-0002pM-VX for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Nov 2016 03:33:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cABwP-0002pD-VT for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 03:33:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cABwM-0000aw-ML for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 03:33:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cABwM-0000an-Iu for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 03:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cABwM-0006yA-DM for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 03:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2016 08:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25025-submit@debbugs.gnu.org id=B25025.148006277426773 (code B ref 25025); Fri, 25 Nov 2016 08:33:02 +0000 Original-Received: (at 25025) by debbugs.gnu.org; 25 Nov 2016 08:32:54 +0000 Original-Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cABwE-0006xl-F8 for submit@debbugs.gnu.org; Fri, 25 Nov 2016 03:32:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cABwC-0006xY-Dr for 25025@debbugs.gnu.org; Fri, 25 Nov 2016 03:32:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cABw2-0000Sm-TM for 25025@debbugs.gnu.org; Fri, 25 Nov 2016 03:32:46 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cABw2-0000Sg-Q3; Fri, 25 Nov 2016 03:32:42 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cABw1-0005QG-UG; Fri, 25 Nov 2016 03:32:42 -0500 In-reply-to: (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel on Fri, 25 Nov 2016 02:03:38 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126071 Archived-At: > From: Clément Pit--Claudel > Date: Fri, 25 Nov 2016 02:03:38 -0500 > > On 2016-11-25 01:24, Fabrice Popineau wrote: > > The python shell name is not passed to any underlying shell. > > It is used to create a process, so it must not be quoted in anyway. > > Are you sure? Looking at the code, I see this: > > (python-shell-make-comint > (or cmd (python-shell-calculate-command)) …) > > And python-shell-make-comint does this: > > (split-string-and-unquote cmd) > > (ok, this is weird). But still, if the command is "C:\Program Files\Python\python.exe", then we *do* need the shell quoting, right? The quoting needs to be done only where a shell command is created that is about to be passed to a shell. I believe in this case the quoting is done too early.