From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 27243@debbugs.gnu.org, antoine.levitt@gmail.com
Subject: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer
Date: Mon, 05 Jun 2017 18:02:14 +0300 [thread overview]
Message-ID: <83poeia361.fsf@gnu.org> (raw)
In-Reply-To: <87d1aiy2qc.fsf@rosalinde> (message from Stephen Berman on Mon, 05 Jun 2017 15:37:47 +0200)
> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Mon, 05 Jun 2017 15:37:47 +0200
> Cc: 27243@debbugs.gnu.org
>
> I think I see why this happens. I assume when you opened "the same
> folder again" you pressed RET on the line in the Dired listing. That
> calls dired-find-file, which calls find-file, which first calls
> find-file-noselect (to see if it's a live buffer), which calls (via
> run-hook-with-args-until-success) dired-noselect, which calls (via
> dired-internal-noselect) revert-buffer (since dired-auto-revert-buffer
> is t), which calls dired-revert, which saves point (via
> dired-save-positions) but then erases the buffer and inserts it anew --
> and this is the problem, because now continuing in find-file, it calls
> switch-to-buffer (since it's a live buffer that you're revisiting),
> which sets window-point by consulting window-prev-buffers. Prior to the
> invocation of erase-buffer, window-prev-buffers contained this entry for
> the buffer being reverted ("test" in my test case):
>
> (#<buffer test> #<marker at 1 in test> #<marker at 232 in test>)
>
> which shows window-point on the first file name in the Dired listing,
> but after erase-buffer it's now this:
>
> (#<buffer test> #<marker at 1 in test> #<marker at 1 in test>)
>
> Since dired-revert restored the saved point (232) but does not return it
> to the caller, switch-to-buffer does not have this information, but only
> what window-prev-buffers shows, which is now 1. So that's what it sets
> window-point to.
Right, I see the same.
> One way to fix this is to make dired-restore-positions restore not only
> point but also window-point. The attached patch does this.
An alternative is to bind switch-to-buffer-preserve-window-point to
nil (the whole problem was caused by the fact that this variable is
now non-nil by default, and dired-revert runs afoul of it, as you
point out):
--- lisp/dired.el~0 2017-02-28 06:27:41.000000000 +0200
+++ lisp/dired.el 2017-06-05 17:51:50.633645200 +0300
@@ -2126,7 +2126,11 @@
(interactive)
;; Bind `find-file-run-dired' so that the command works on directories
;; too, independent of the user's setting.
- (let ((find-file-run-dired t))
+ (let ((find-file-run-dired t)
+ (switch-to-buffer-preserve-window-point
+ (if dired-auto-revert-buffer
+ nil
+ switch-to-buffer-preserve-window-point)))
(find-file (dired-get-file-for-visit))))
(defun dired-find-alternate-file ()
I'm not sure which solution is better. Maybe someone will come up
with a more elegant one.
Thanks.
next prev parent reply other threads:[~2017-06-05 15:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 23:45 bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer Antoine Levitt
2017-06-05 13:37 ` Stephen Berman
2017-06-05 15:02 ` Eli Zaretskii [this message]
2017-06-05 15:15 ` Stephen Berman
2017-06-05 16:20 ` Eli Zaretskii
2017-06-10 8:24 ` Eli Zaretskii
[not found] ` <CABfD5m0==QAKYoJDkaPQxoyS1BQT-eTQJLmYZC6Z-V5A0jfeig@mail.gmail.com>
2017-06-10 8:45 ` Antoine Levitt
[not found] ` <handler.27243.D27243.14970831096548.notifdone@debbugs.gnu.org>
2017-06-17 12:16 ` bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer) Antoine Levitt
2017-06-17 13:32 ` Stephen Berman
2017-07-09 17:37 ` Antoine Levitt
2017-07-14 9:56 ` Stephen Berman
2017-07-15 5:52 ` John Wiegley
2017-07-15 7:18 ` Eli Zaretskii
2017-07-17 9:22 ` Stephen Berman
2017-07-22 15:28 ` Antoine Levitt
2017-07-22 16:55 ` Glenn Morris
2017-07-22 22:48 ` Stephen Berman
2017-07-22 22:48 ` bug#27243: another case: dired-auto-revert-buffer jumps point to beginning of buffer Stephen Berman
2017-07-23 14:43 ` Eli Zaretskii
2017-07-23 18:40 ` martin rudalics
2017-07-23 18:58 ` Eli Zaretskii
2017-07-23 21:09 ` martin rudalics
2017-07-28 8:49 ` Stephen Berman
2017-07-28 9:28 ` Eli Zaretskii
2017-07-28 12:22 ` martin rudalics
2017-07-28 13:02 ` Stefan Monnier
2017-07-28 13:12 ` Eli Zaretskii
2017-07-28 13:16 ` Stefan Monnier
2017-07-28 13:41 ` Eli Zaretskii
2017-07-28 14:14 ` martin rudalics
2017-07-28 14:45 ` Eli Zaretskii
2017-07-28 14:54 ` Stephen Berman
2017-07-29 11:44 ` Stephen Berman
2020-05-25 4:21 ` Michael Heerdegen
[not found] ` <874ks4ekpg.fsf@web.de>
2020-05-25 7:26 ` Stephen Berman
2020-05-25 23:36 ` Michael Heerdegen
2020-05-27 1:23 ` Michael Heerdegen
2020-05-27 5:36 ` Michael Heerdegen
2020-05-27 14:52 ` martin rudalics
2020-05-27 17:01 ` Michael Heerdegen
2020-05-27 17:56 ` martin rudalics
2020-05-30 22:11 ` Juri Linkov
2020-05-26 8:02 ` martin rudalics
2020-05-27 1:16 ` Michael Heerdegen
2017-07-15 7:36 ` bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer) martin rudalics
2017-07-15 11:14 ` Stephen Berman
2017-07-15 13:59 ` martin rudalics
2017-07-17 9:28 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83poeia361.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27243@debbugs.gnu.org \
--cc=antoine.levitt@gmail.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.