From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: dired-tests.el fails on MS-Windows
Date: Tue, 01 Aug 2017 22:04:26 +0300 [thread overview]
Message-ID: <83pocfyurp.fsf@gnu.org> (raw)
In-Reply-To: <87d18fw79z.fsf@calancha-pc> (message from Tino Calancha on Wed, 02 Aug 2017 02:02:32 +0900)
> From: Tino Calancha <tino.calancha@gmail.com>
> Cc: emacs-devel@gnu.org, tino.calancha@gmail.com
> Date: Wed, 02 Aug 2017 02:02:32 +0900
>
> > dired-tests.log:
> > Test dired-test-bug25609 condition:
> > (ert-test-failed
> > ((should
> > (file-exists-p target))
> > :form
> > (file-exists-p "c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/bar6828Ler/foo6828WPJ")
> > :value nil))
> Could you check the following?
I could, but I don't understand the purpose. This form is almost
identical to what's in dired-tests.el, and I already established that
the failure is indeed because 'target' doesn't exist at that moment.
I just didn't dig deep enough to understand why, because I didn't
really understand what the code wants to do, e.g. why it calls
dired-do-copy twice, and more importantly why 'target' is supposed to
exist after all that.
What I see here is that at the point where file-exists-p is called,
there are two directories: /bla/blah/foNNNNNN and /bla/bla/barKKKKKK,
but not /bla/bla/fooNNNNN/barKKKKKK, as I think the code expects.
maybe if you could explain the idea behind the code I could think of a
reason why it doesn't work here.
> > Test dired-test-bug27631 backtrace:
> > signal(error ("em-ls is not a currently loaded feature"))
> > error("%s is not a currently loaded feature" "em-ls")
> > unload-feature(em-ls force)
> > (unwind-protect (progn (make-directory dir1) (make-directory dir2) (
> > (let* ((dir (make-temp-file "bug27631" 'dir)) (dir1 (expand-file-nam
> > (closure (t) nil (let* ((dir (make-temp-file "bug27631" 'dir)) (dir1
> > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> > ert-run-test(#s(ert-test :name dired-test-bug27631 :documentation "T
> > ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
> > ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
> > ert-run-tests-batch(nil)
> > ert-run-tests-batch-and-exit(nil)
> > eval((ert-run-tests-batch-and-exit nil))
> > command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/dired-tests.el" "--e
> > command-line()
> > normal-top-level()
> > Test dired-test-bug27631 condition:
> > (error "em-ls is not a currently loaded feature")
> I don't get this error, but the idea of require
> those libs and unload them looks ugly.
I think we need to understand why the problem happens before we decide
how to proceed.
> > ediff-ptch-tests.log:
> >
> > Running 2 tests (2017-08-01 18:21:40+0300)
> > passed 1/2 ediff-ptch-test-bug25010
> > Test ediff-ptch-test-bug26084 backtrace:
> > Test ediff-ptch-test-bug26084 condition:
> > (wrong-type-argument stringp nil)
> > FAILED 2/2 ediff-ptch-test-bug26084
> I think this test for Bug#26084 is more complicated than the
> fix of the bug itself. It has also problems because the different
> idiosyncrasy respect to "-b" option for different versions of "patch".
> Delete it?
I don't know. What does it try to test?
> Skipped it unless in a GNU system?
Only if there's no better way. The Patch invocation definitely needs
the --binary switch on Windows, though. But the failure above is not
about that, it's about something else, because directory-files returns
an empty list. Something prevents Patch from creating backup files.
next prev parent reply other threads:[~2017-08-01 19:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 15:22 dired-tests.el fails on MS-Windows Eli Zaretskii
2017-08-01 17:02 ` Tino Calancha
2017-08-01 19:04 ` Eli Zaretskii [this message]
2017-08-01 20:56 ` Fabrice Popineau
2017-08-02 6:44 ` Tino Calancha
2017-08-04 13:18 ` Eli Zaretskii
2017-08-04 13:30 ` Fabrice Popineau
2017-08-04 13:44 ` Tino Calancha
2017-08-04 14:01 ` Fabrice Popineau
2017-08-04 14:00 ` Eli Zaretskii
2017-08-04 5:21 ` Tino Calancha
2017-08-04 13:14 ` Eli Zaretskii
2017-08-04 13:39 ` Tino Calancha
2017-08-04 14:23 ` Fabrice Popineau
2017-08-04 14:39 ` Fabrice Popineau
2017-08-04 14:49 ` Tino Calancha
2017-08-04 14:58 ` Fabrice Popineau
2017-08-04 15:10 ` Tino Calancha
2017-08-01 20:52 ` Fabrice Popineau
2017-08-02 3:38 ` Tino Calancha
2017-08-02 6:31 ` Michael Albinus
2017-08-02 7:59 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pocfyurp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.