From: Eli Zaretskii <eliz@gnu.org>
To: Vasilij Schneidermann <v.schneidermann@gmail.com>
Cc: larsi@gnus.org, 28402@debbugs.gnu.org
Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
Date: Mon, 11 Sep 2017 19:04:42 +0300 [thread overview]
Message-ID: <83poaxrzl1.fsf@gnu.org> (raw)
In-Reply-To: <CAPGgwWRQCPkviThdT3R2VOrdgZ79c=A01s6DmYqdv6VMFA56Kg@mail.gmail.com> (message from Vasilij Schneidermann on Sat, 9 Sep 2017 21:39:39 +0200)
> From: Vasilij Schneidermann <v.schneidermann@gmail.com>
> Date: Sat, 9 Sep 2017 21:39:39 +0200
> Cc: larsi@gnus.org
>
> I'm using shr.el for a package and override `shr-tag-img` by let-binding
> `shr-external-rendering-functions` to an alist containing an alternative
> rendering function that deals better with local images. Despite this
> `shr-tag-img` is still directly called when rendering tables with images
> inside them. The same problem applies to other directly called
> rendering functions, as opposed to indirectly called ones as seen in
> `shr-descend`, the function honoring `shr-external-rendering-functions`.
From a cursory look into shr.el, it looks like
shr-external-rendering-functions were introduced to support some
specific eww.el needs, not as a general lever for tweaking shr.el from
outside it. That's why only a handful of functions honor that
variable.
Would you like to submit a patch that would make all shr-tag-*
functions consult that variable first?
next prev parent reply other threads:[~2017-09-11 16:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 19:39 bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Vasilij Schneidermann
2017-09-11 16:04 ` Eli Zaretskii [this message]
2017-09-13 17:22 ` Vasilij Schneidermann
2017-09-13 18:37 ` Eli Zaretskii
2017-09-24 13:10 ` Vasilij Schneidermann
2017-09-29 7:31 ` Eli Zaretskii
2017-10-05 10:02 ` Eli Zaretskii
2017-10-05 10:18 ` Lars Ingebrigtsen
2017-10-05 11:01 ` Eli Zaretskii
2017-10-05 11:18 ` Lars Ingebrigtsen
2017-10-05 13:14 ` Eli Zaretskii
2017-10-05 13:22 ` Lars Ingebrigtsen
2017-10-05 13:44 ` Eli Zaretskii
2017-10-05 13:52 ` Lars Ingebrigtsen
2017-10-05 20:08 ` Vasilij Schneidermann
2017-10-05 20:10 ` Lars Ingebrigtsen
2017-10-06 12:43 ` Eli Zaretskii
2017-09-13 17:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83poaxrzl1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28402@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=v.schneidermann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.