From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Thu, 05 Oct 2017 16:44:57 +0300 Message-ID: <83poa1wvxi.fsf@gnu.org> References: <83poaxrzl1.fsf@gnu.org> <20170913172232.7jwwomyfmy567nrx@odonien.localdomain> <83lglio36q.fsf@gnu.org> <20170924131050.6erv6sshvz23dlbu@odonien.localdomain> <838tgy9d18.fsf@gnu.org> <877ew9vqwv.fsf@mouse.gnus.org> <83vajtx3hu.fsf@gnu.org> <87wp49u9ki.fsf@mouse.gnus.org> <83shexwxce.fsf@gnu.org> <87lgkpu3tl.fsf@mouse.gnus.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507211182 11135 195.159.176.226 (5 Oct 2017 13:46:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 13:46:22 +0000 (UTC) Cc: v.schneidermann@gmail.com, 28402@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 15:46:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e06Ta-0001gA-ON for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 15:46:11 +0200 Original-Received: from localhost ([::1]:39918 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e06Tg-00062X-Fv for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 09:46:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e06TW-000627-BJ for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:46:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e06TS-0004Lr-Gr for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41242) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e06TS-0004LS-D4 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e06TR-0008Sf-S4 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150721112832481 (code B ref 28402); Thu, 05 Oct 2017 13:46:01 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 5 Oct 2017 13:45:28 +0000 Original-Received: from localhost ([127.0.0.1]:49923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e06Sq-0008Rm-Ci for submit@debbugs.gnu.org; Thu, 05 Oct 2017 09:45:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e06Sl-0008RS-LQ for 28402@debbugs.gnu.org; Thu, 05 Oct 2017 09:45:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e06Sa-0003bZ-Od for 28402@debbugs.gnu.org; Thu, 05 Oct 2017 09:45:14 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e06Sa-0003bD-La; Thu, 05 Oct 2017 09:45:08 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3268 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e06Sa-0004Qu-3P; Thu, 05 Oct 2017 09:45:08 -0400 In-reply-to: <87lgkpu3tl.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Thu, 05 Oct 2017 15:22:46 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137973 Archived-At: > From: Lars Ingebrigtsen > Cc: v.schneidermann@gmail.com, 28402@debbugs.gnu.org > Date: Thu, 05 Oct 2017 15:22:46 +0200 > > Eli Zaretskii writes: > > > What if we make shr-indirect-call a defsubst? Would that take care of > > this issue? > > Isn't it still (at least) an extra stack frame with a bunch of variable > bindings? Yes, but is that really that significant? You sound like saying that any non-trivial change in shr-descend should be rejected for these reasons. Is that really so? Do we have measurements that would back up such extreme care? > This function is the central bit in shr, and should be as fast as > possible. As fast as possible, but not faster, I presume ;-) Anyway, I see your point. Vasilij, any thoughts or suggestions to avoid reverting that part, while still keeping Lars happy?