From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: 28710@debbugs.gnu.org
Subject: bug#28710: 27.0.50; eassert failure in maybe_produce_line_number
Date: Sun, 08 Oct 2017 22:50:45 +0300 [thread overview]
Message-ID: <83po9xs9ka.fsf@gnu.org> (raw)
In-Reply-To: <871smd1muu.fsf@gmail.com> (message from Alex on Sun, 08 Oct 2017 13:05:45 -0600)
> From: Alex <agrambot@gmail.com>
> Cc: 28710@debbugs.gnu.org
> Date: Sun, 08 Oct 2017 13:05:45 -0600
>
> The return value appears to be true. The breakpoint does trigger right
> after, and enabled_p is also true:
>
> Thread 1 "emacs" hit Hardware watchpoint 4: -location $1->desired_matrix->rows->enabled_p
>
> Old value = false
> New value = true
> prepare_desired_row (w=0x1695d60 <bss_sbrk_buffer+8894272>, row=0x4182860,
> mode_line_p=true) at dispnew.c:1076
> 1076 row->reversed_p = rp;
> (gdb) c
> Continuing.
>
> Thread 1 "emacs" hit Hardware watchpoint 4: -location $1->desired_matrix->rows->enabled_p
>
> Old value = true
> New value = false
> clear_glyph_matrix_rows (matrix=0x3f524f0, start=0, end=37) at dispnew.c:693
> 693 for (; start < end; ++start)
> (gdb) c
> Continuing.
>
> Thread 1 "emacs" hit Hardware watchpoint 4: -location $1->desired_matrix->rows->enabled_p
>
> Old value = false
> New value = true
> prepare_desired_row (w=0x1695d60 <bss_sbrk_buffer+8894272>, row=0x4182860,
> mode_line_p=false) at dispnew.c:1076
> 1076 row->reversed_p = rp;
> (gdb) break xdisp.c:17039
> Breakpoint 5 at 0x474844: file xdisp.c, line 17039.
> (gdb) commands
> Type commands for breakpoint(s) 5, one per line.
> End with a line saying just "end".
> >p w->desired_matrix->rows->enabled_p
> >end
> (gdb) finish
> Run till exit from #0 prepare_desired_row (
> w=0x1695d60 <bss_sbrk_buffer+8894272>, row=0x4182860, mode_line_p=false)
> at dispnew.c:1076
> display_line (it=0x7ffefb255dc0, cursor_vpos=25) at xdisp.c:21208
> warning: Source file is more recent than executable.
> 21208 row->y = it->current_y;
> (gdb) finish
> Run till exit from #0 display_line (it=0x7ffefb255dc0, cursor_vpos=25)
> at xdisp.c:21208
> 0x0000000000477380 in try_window (window=XIL(0x1695d65), pos=..., flags=1)
> at xdisp.c:17592
> 17592 if (display_line (&it, cursor_vpos))
> Value returned is $2 = true
> (gdb) finish
> Run till exit from #0 0x0000000000477380 in try_window (
> window=XIL(0x1695d65), pos=..., flags=1) at xdisp.c:17592
> 0x0000000000474866 in redisplay_window (window=XIL(0x1695d65),
> just_this_one_p=false) at xdisp.c:17039
> 17039 if (try_window (window, startp, TRY_WINDOW_CHECK_MARGINS) < 0)
> Value returned is $3 = 1
> (gdb) continue
> Continuing.
>
> Thread 1 "emacs" hit Breakpoint 5, redisplay_window (window=XIL(0x1695d65), just_this_one_p=false) at xdisp.c:17039
> 17039 if (try_window (window, startp, TRY_WINDOW_CHECK_MARGINS) < 0)
> $4 = true
> (gdb) p w->desired_matrix->rows->enabled_p
> $5 = true
OK, so we need to understand the path the code takes after try_window
returns the value 1. This means, after typing "finish" 3 times, type
"next", then continue pressing RET until redisplay_window returns. I
need to see the path through the code until we exit redisplay_window
to understand where to put the missing call to clear_glyph_matrix.
Also, please recompile Emacs because:
> warning: Source file is more recent than executable.
Thanks.
> Have you tried using MELPA[1] to install magit? Maybe that would
> work.
I'm not sure how will this help. I don't want to install Magit, I
just use it from a directory where I unzipped its snapshot. How using
MELPA would change that?
next prev parent reply other threads:[~2017-10-08 19:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 22:31 bug#28710: 27.0.50; eassert failure in maybe_produce_line_number Alex
2017-10-05 8:30 ` Eli Zaretskii
2017-10-05 23:51 ` Alex
2017-10-06 8:38 ` Eli Zaretskii
2017-10-07 23:05 ` Alex
2017-10-08 6:29 ` Eli Zaretskii
2017-10-08 7:11 ` Alex
2017-10-08 9:35 ` Eli Zaretskii
2017-10-08 10:09 ` Eli Zaretskii
2017-10-09 13:03 ` Eli Zaretskii
2017-10-08 19:05 ` Alex
2017-10-08 19:50 ` Eli Zaretskii [this message]
2017-10-08 21:19 ` Alex
2017-10-09 12:40 ` Eli Zaretskii
2017-10-09 17:56 ` Alex
2017-10-09 18:51 ` Eli Zaretskii
2017-10-09 19:36 ` Alex
2017-10-10 6:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83po9xs9ka.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28710@debbugs.gnu.org \
--cc=agrambot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.