From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el Date: Mon, 09 Oct 2017 19:18:14 +0300 Message-ID: <83po9wqoqh.fsf@gnu.org> References: <20171009134715.11038.14309@vcs0.savannah.gnu.org> <20171009134716.77ADE201F1@vcs0.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507566100 20335 195.159.176.226 (9 Oct 2017 16:21:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Oct 2017 16:21:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 09 18:21:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1ao7-0004Cw-5W for ged-emacs-devel@m.gmane.org; Mon, 09 Oct 2017 18:21:31 +0200 Original-Received: from localhost ([::1]:58769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1aoD-0001Lc-36 for ged-emacs-devel@m.gmane.org; Mon, 09 Oct 2017 12:21:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1alG-0007sG-0g for emacs-devel@gnu.org; Mon, 09 Oct 2017 12:18:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1alC-0006Pv-To for emacs-devel@gnu.org; Mon, 09 Oct 2017 12:18:34 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1alC-0006Po-Ps; Mon, 09 Oct 2017 12:18:30 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1alC-0002E8-6e; Mon, 09 Oct 2017 12:18:30 -0400 In-reply-to: (message from Stefan Monnier on Mon, 09 Oct 2017 11:57:11 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219310 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Mon, 09 Oct 2017 11:57:11 -0400 > > > - (set (make-local-variable (car local)) > > - (cdr local))))) > > + ;; Cloning message-default-charset could cause an already > > + ;; encoded text to be encoded again, yielding raw bytes > > + ;; instead of characters in the message. > > + (unless (string-match "message-default-charset" > > + (symbol-name (car local))) > > + (set (make-local-variable (car local)) > > + (cdr local)))))) > > Could you add a comment explaining why we do > > (string-match "message-default-charset" (symbol-name (car local)) > > rather than > > (eq 'message-default-charset (car local)) No reason except that this was in the patch proposed by Alex. Feel free to change.