From: Eli Zaretskii <eliz@gnu.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: emacs-devel@gnu.org
Subject: Re: Adding new variable for face-list in internal-make-lisp-face.
Date: Fri, 03 Nov 2017 12:17:05 +0200 [thread overview]
Message-ID: <83po8zvf8e.fsf@gnu.org> (raw)
In-Reply-To: <m2h8ucm354.wl%esq@lawlist.com> (message from Keith David Bershatsky on Thu, 02 Nov 2017 20:50:47 -0700)
> Date: Thu, 02 Nov 2017 20:50:47 -0700
> From: Keith David Bershatsky <esq@lawlist.com>
>
> In implementing feature requests crosshairs (17684) and multiple fake cursors (22873), I thought it would be nifty to identify the background color (if applicable) associated with a tab ('\t') glyph code in the buffer-display-table. In doing so, I discovered that the Lisp function face-list is way too slow. Even after I ported the face-list function over to C, it was still way too slow. So, I tried my luck at adding a new variable in xfaces.c for the face-list and am setting it from within the function internal-make-lisp-face, like so:
I don't understand why you need face-list for this. For each glyph in
the display table, you get its face ID by using the GLYPH_FACE macro.
Why isn't that sufficient for your needs?
next prev parent reply other threads:[~2017-11-03 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 3:50 Adding new variable for face-list in internal-make-lisp-face Keith David Bershatsky
2017-11-03 10:17 ` Eli Zaretskii [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-03 22:01 Keith David Bershatsky
2017-11-04 8:05 ` Eli Zaretskii
2017-11-04 6:56 Keith David Bershatsky
2017-11-04 8:13 ` Eli Zaretskii
2017-11-04 17:46 Keith David Bershatsky
2017-11-04 18:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83po8zvf8e.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.