all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: emacs-devel@gnu.org
Subject: Re: fix for bug#29935 copyright-update inserts year at random places
Date: Mon, 08 Jan 2018 21:05:25 +0200	[thread overview]
Message-ID: <83po6k6uiy.fsf@gnu.org> (raw)
In-Reply-To: <86o9m4gug4.fsf@stephe-leake.org> (message from Stephen Leake on Mon, 08 Jan 2018 10:56:59 -0600)

> From: Stephen Leake <stephen_leake@stephe-leake.org>
> Date: Mon, 08 Jan 2018 10:56:59 -0600
> 
> This thread is nominally about patching emacs-26 to fix a bug. The patch
> I've posted is a minimal fix; adding code or redesigning to handle frames
> better is feature-creep, so it should be done on master.

I think the bug happens because we use save-window-excursion, and
switch buffers inside it.  The cure should be not to do what hurts.
Can this be done in this case?  If not, why not?  And why do we use
save-window-excursion in the first place? that's not the usual way to
display a buffer whose contents is referenced in an error message or a
prompt.

Thanks.



  parent reply	other threads:[~2018-01-08 19:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 23:29 fix for bug#29935 copyright-update inserts year at random places Stephen Leake
2018-01-02  9:21 ` Lele Gaifax
2018-01-02 16:03 ` Eli Zaretskii
2018-01-03 22:52   ` Stephen Leake
2018-01-04  1:01     ` Stefan Monnier
2018-01-04  3:21       ` Stephen Leake
2018-01-04  5:34         ` Stefan Monnier
2018-01-04 12:47           ` Stephen Leake
2018-01-04 18:23             ` Stefan Monnier
2018-01-07 16:08             ` martin rudalics
2018-01-07 17:34               ` Stefan Monnier
2018-01-08  9:53                 ` martin rudalics
2018-01-08 13:15                   ` Stefan Monnier
2018-01-08 16:56                     ` Stephen Leake
2018-01-08 18:37                       ` martin rudalics
2018-01-08 19:05                       ` Eli Zaretskii [this message]
2018-01-11 16:48                         ` Stephen Leake
2018-01-08 18:18                     ` martin rudalics
2018-01-08 22:18                       ` Stefan Monnier
2018-01-09  9:42                         ` martin rudalics
2018-01-09 13:07                           ` Stefan Monnier
2018-01-10 10:19                             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83po6k6uiy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stephen_leake@stephe-leake.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.