From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs-26 build breaking on RHEL 6.6 GTK2
Date: Wed, 24 Jan 2018 22:10:27 +0200
Message-ID: <83po5zm30s.fsf@gnu.org>
References: <CAFyQvY1ZpVKdCE-b9Fo_ZCu_g1SS2Q7sOKw6_Js5Cqyk-xU47w@mail.gmail.com>
	<ja4lnbkv4m.fsf@fencepost.gnu.org> <874lnbjfp0.fsf@gmail.com>
	<5A68D141.30708@gmx.at> <87vafrhzfs.fsf@gmail.com>
	<5A68D4AB.9080505@gmx.at> <87r2qfhyxi.fsf@gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1516824539 4994 195.159.176.226 (24 Jan 2018 20:08:59 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 24 Jan 2018 20:08:59 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 24 21:08:55 2018
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1eeRLe-0000Ed-B0
	for ged-emacs-devel@m.gmane.org; Wed, 24 Jan 2018 21:08:42 +0100
Original-Received: from localhost ([::1]:42919 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1eeRNd-0003Z3-5v
	for ged-emacs-devel@m.gmane.org; Wed, 24 Jan 2018 15:10:45 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35484)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1eeRNW-0003YD-8T
	for emacs-devel@gnu.org; Wed, 24 Jan 2018 15:10:39 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1eeRNS-0001cM-Vo
	for emacs-devel@gnu.org; Wed, 24 Jan 2018 15:10:38 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54500)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1eeRNS-0001cD-Q7; Wed, 24 Jan 2018 15:10:34 -0500
Original-Received: from [176.228.60.248] (port=3058 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1eeRNS-00055r-4T; Wed, 24 Jan 2018 15:10:34 -0500
In-reply-to: <87r2qfhyxi.fsf@gmail.com> (message from Robert Pluim on Wed, 24
	Jan 2018 19:52:25 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:222207
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/222207>

> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 24 Jan 2018 19:52:25 +0100
> Cc: emacs-devel@gnu.org
> 
> martin rudalics <rudalics@gmx.at> writes:
> 
> >> 3.4.2? That's bizarre.
> >
> > It's defined only since GDK 3.10.
> 
> Which I didn't find in the GTK doc. Definitely back to the drawing
> board on these changes.

Why not simply change the prerequisite for the GTK version number, and
leave the rest of the patch alone?  IOW, instead of checking HAVE_GTK3
test GTK_CHECK_VERSION (3, 10, 0).  Would that work?