From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version' Date: Fri, 16 Feb 2018 19:22:20 +0200 Message-ID: <83po54df3n.fsf@gnu.org> References: <20180216093116.572.67356@vcs0.savannah.gnu.org> <20180216093117.66FB5206A2@vcs0.savannah.gnu.org> <4finawzxei.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518801706 26187 195.159.176.226 (16 Feb 2018 17:21:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Feb 2018 17:21:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 16 18:21:42 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emjhM-0005T2-IX for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 18:21:24 +0100 Original-Received: from localhost ([::1]:42441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emjjO-0005Vn-J0 for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 12:23:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emjiL-0005Tu-KU for emacs-devel@gnu.org; Fri, 16 Feb 2018 12:22:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emjiH-0004O8-Mq for emacs-devel@gnu.org; Fri, 16 Feb 2018 12:22:25 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emjiH-0004O0-Il for emacs-devel@gnu.org; Fri, 16 Feb 2018 12:22:21 -0500 Original-Received: from [176.228.60.248] (port=2535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emjiG-00027U-QQ; Fri, 16 Feb 2018 12:22:21 -0500 In-reply-to: <4finawzxei.fsf@fencepost.gnu.org> (message from Glenn Morris on Fri, 16 Feb 2018 11:56:05 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222832 Archived-At: > From: Glenn Morris > Cc: Eli Zaretskii > Date: Fri, 16 Feb 2018 11:56:05 -0500 > > > * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to > > work with Git for Windows. > > - (string-match "git version \\([0-9.]+\\)$" > > - version-string)) > > + ;; Git for Windows appends ".windows.N" to the > > + ;; numerical version reported by Git. > > + (string-match > > + "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$" > > + version-string)) > > Surely this breaks on all non-MS Windows platforms? Given how much time it was "broken" on Windows without anyone noticing, isn't it just fair that we leave it "broken" on non-Windows platforms for approximately the same time?